[backport#14690] Throw error if CPubKey is invalid during PSBT keypath serialization
ClosedPublic
Actions

Authored by majcosta on May 11 2020, 15:43.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGd59cda9c1b4d: [backport#14690] Throw error if CPubKey is invalid during PSBT keypath…
rABCd59cda9c1b4d: [backport#14690] Throw error if CPubKey is invalid during PSBT keypath…

Summary

Related to #14689

We should catch this error before attempting to deserialize it later.

Depends on D6029

This is a backport of Core PR14690

Test Plan

cmake .. -GNinja -DENABLE_WERROR=ON
ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr14689

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10688
Build 19173: Default Diff Build & Tests
Build 19172: arc lint + arc unit

Event Timeline

majcosta created this revision.May 11 2020, 15:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 11 2020, 15:43

majcosta requested review of this revision.May 11 2020, 15:43

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10688: Diff 19890.May 11 2020, 15:53

deadalnix accepted this revision.May 11 2020, 16:29

This revision is now accepted and ready to land.May 11 2020, 16:29

Closed by commit rABCd59cda9c1b4d: [backport#14690] Throw error if CPubKey is invalid during PSBT keypath… (authored by Gregory Sanders <gsanders87@gmail.com>, committed by majcosta). · Explain WhyMay 11 2020, 16:58

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCd59cda9c1b4d: [backport#14690] Throw error if CPubKey is invalid during PSBT keypath….

majcosta added a commit: rSTAGINGd59cda9c1b4d: [backport#14690] Throw error if CPubKey is invalid during PSBT keypath….

Revision Contents
Changeset List

Path

Size

src/

script/

sign.h

3 lines

Diff 19890

View Options

[backport#14690] Throw error if CPubKey is invalid during PSBT keypath serializationClosedPublicActions