Page MenuHomePhabricator
Differential D6196

[refactor] Combine the ToString and ToPrivateString implementations
ClosedPublic
Actions

Authored by deadalnix on May 21 2020, 14:54.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC0378eb56a090: [refactor] Combine the ToString and ToPrivateString implementations
Summary

This is a partial backport of Core PR14646 : https://github.com/bitcoin/bitcoin/pull/14646/commits/1eda33aabc15b905a1e23ffab648ecf2a8f5322b

Depends on D6195

Test Plan
ninja all check-all

Diff Detail

Event Timeline

deadalnix created this revision.May 21 2020, 14:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2020, 14:54
deadalnix requested review of this revision.May 21 2020, 14:54
teamcity edited the summary of this revision. (Show Details)May 21 2020, 14:54

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix added a child revision: D6197: Add descriptor expansion cache.May 21 2020, 14:59
teamcity added a comment.May 21 2020, 15:10

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 21 2020, 15:12

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 21 2020, 15:12

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 21 2020, 15:15

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 21 2020, 15:15

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

majcosta requested changes to this revision.May 21 2020, 15:17
majcosta added a subscriber: majcosta.

wrong commit link on summary

This revision now requires changes to proceed.May 21 2020, 15:17
deadalnix requested review of this revision.May 21 2020, 15:24
deadalnix edited the summary of this revision. (Show Details)

Updated

teamcity added a comment.May 21 2020, 15:26

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10940: Diff 20458.May 21 2020, 15:26
majcosta accepted this revision.May 21 2020, 15:31
This revision is now accepted and ready to land.May 21 2020, 15:31
Closed by commit rABC0378eb56a090: [refactor] Combine the ToString and ToPrivateString implementations (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyMay 21 2020, 15:39
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC0378eb56a090: [refactor] Combine the ToString and ToPrivateString implementations.

Revision Contents
Changeset List

PathSize
src/
script/
38 lines

Diff 20458

View Options

src/script/descriptor.cpp

Loading...