Differential D6865

Remove confusing statement from setban RPC help text
ClosedPublic
Actions

Authored by jasonbcox on Jul 9 2020, 00:54.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC4cb8140d0d78: Remove confusing statement from setban RPC help text

Summary

This statement is not technically true, as restarting the node
will revert automatic/discouraging bans.

This brings our code more inline with Core.

Test Plan

ninja
bitcoind
bitcoin-cli help setban    # verify new help text

Diff Detail

Repository

rABC Bitcoin ABC

Branch

setban-help-fix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11916
Build 23605: Default Diff Build & Tests	Link to the build
Build 23604: Build without Wallet	Link to the build
Build 23603: Build with clang-10	Link to the build
Build 23602: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jul 9 2020, 00:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2020, 00:54

jasonbcox requested review of this revision.Jul 9 2020, 00:54

deadalnix accepted this revision.Jul 9 2020, 01:02

This revision is now accepted and ready to land.Jul 9 2020, 01:02

Harbormaster completed remote builds in B11916: Diff 22100.Jul 9 2020, 01:10

Closed by commit rABC4cb8140d0d78: Remove confusing statement from setban RPC help text (authored by jasonbcox). · Explain WhyJul 9 2020, 15:38

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC4cb8140d0d78: Remove confusing statement from setban RPC help text.

Revision Contents
Changeset List

Path

Size

src/

rpc/

net.cpp

3 lines

Diff 22100

View Options

Remove confusing statement from setban RPC help textClosedPublicActions