Differential D7112

[backport#17154 1/3][wallet] Add doxygen comment to CWallet::CommitTransaction()
ClosedPublic
Actions

Authored by majcosta on Aug 1 2020, 15:03.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC973e07b9f458: [backport#17154 1/3][wallet] Add doxygen comment to CWallet::CommitTransaction()

Summary

https://github.com/bitcoin/bitcoin/pull/17154/commits/b6f486a02b463ffeaf82ec11fc6f74f439c037ae

note: the first commit
(https://github.com/bitcoin/bitcoin/pull/17154/commits/8bba91b22d22a8dfea7c947b542b1022bfc1c0ea) didn't really apply to us.

Depends on D7111

Partial backport of Core PR17154

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12277
Build 24761: Build Diff	build-without-wallet · build-clang-tidy · build-clang-10 · build-diff
Build 24760: arc lint + arc unit

Event Timeline

majcosta created this revision.Aug 1 2020, 15:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 1 2020, 15:03

majcosta requested review of this revision.Aug 1 2020, 15:03

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D7113: [backport#17154 2/3][wallet] Remove return value from CommitTransaction().Aug 1 2020, 15:12

Harbormaster completed remote builds in B12277: Diff 22693.Aug 1 2020, 15:15

Fabien accepted this revision.Aug 3 2020, 09:17

This revision is now accepted and ready to land.Aug 3 2020, 09:17

Closed by commit rABC973e07b9f458: [backport#17154 1/3][wallet] Add doxygen comment to CWallet::CommitTransaction() (authored by John Newbery <john@johnnewbery.com>, committed by majcosta). · Explain WhyAug 5 2020, 05:07

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC973e07b9f458: [backport#17154 1/3][wallet] Add doxygen comment to CWallet::CommitTransaction().

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.h

12 lines

wallet.cpp

3 lines

Diff 22693

View Options

src/wallet/wallet.h