Differential D8605

Bump DEFAULT_MAX_PEER_CONNECTIONS to 4096
ClosedPublic
Actions

Authored by deadalnix on Dec 4 2020, 16:49.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC537d1a1e42c2: Bump DEFAULT_MAX_PEER_CONNECTIONS to 4096

Summary

With avalanche, we'll have to keep in touch with more nodes.

Test Plan

ninja all check-all

Kept a node running for a while and check that resource consumption is not out of wack.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

netmaxcon

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14314
Build 28603: Build Diff	build-clang · build-without-wallet · lint-circular-dependencies · build-diff · build-clang-tidy · build-debug
Build 28602: arc lint + arc unit

Event Timeline

deadalnix created this revision.Dec 4 2020, 16:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 4 2020, 16:49

deadalnix requested review of this revision.Dec 4 2020, 16:49

Reduce the max connection used by default in integration tests as to not exaust the available file descriptors when many nodes are running at once.

Harbormaster completed remote builds in B14310: Diff 26194.Dec 4 2020, 17:08

Harbormaster completed remote builds in B14311: Diff 26195.Dec 4 2020, 17:21

majcosta accepted this revision.Dec 4 2020, 17:26

This revision is now accepted and ready to land.Dec 4 2020, 17:26

majcosta added inline comments.Dec 4 2020, 19:51

src/net.h
91 ↗	(On Diff #26195)	4096*

Fix warnings in bitcoin-qt and log due to an error in the the required descriptor count calcuation.

This error exists in Core too, but never triggers because the system pretty much always provide enough descriptor by default and the value doesn't need to be increased.

This revision was landed with ongoing or failed builds.Dec 5 2020, 00:58

Closed by commit rABC537d1a1e42c2: Bump DEFAULT_MAX_PEER_CONNECTIONS to 4096 (authored by deadalnix). · Explain Why

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC537d1a1e42c2: Bump DEFAULT_MAX_PEER_CONNECTIONS to 4096.

Harbormaster completed remote builds in B14314: Diff 26198.Dec 5 2020, 01:07

Fabien mentioned this in D8628: Fix the functional tests on platforms using select() instead of poll().Dec 8 2020, 14:02

Fabien mentioned this in rABC854580d15597: Fix the functional tests on platforms using select() instead of poll().Dec 8 2020, 14:36

Fabien mentioned this in D8894: Update -blocksonly documentation.Jan 13 2021, 11:08

Fabien mentioned this in D10974: Increase our max number of outbound peers.Feb 3 2022, 14:00

Fabien mentioned this in rABC6f628bcb1267: Increase our max number of outbound peers.Feb 4 2022, 10:25