Page MenuHomePhabricator

[Web - New] Adding cashtab-components source
ClosedPublic

Authored by bytesofman on Jan 27 2021, 21:01.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC6705b69d8931: [Web - New] Adding cashtab-components source
Summary

Adds source code of published npm package, cashtab-components. Codebase currently available at https://github.com/josephroyking/cashtab-components. NPM module here: https://www.npmjs.com/package/cashtab-components. This was refactored from https://github.com/Bitcoin-com/badger-components-react , adding typescript, upgrading React, and upgrading Storybook. Starting point here because TypeScript refactor of original source code proved more involved than foreseen, more an overhaul than a diff.

Test Plan
cd web/cashtab-components
npm ci
npm run storybook

Component library will load at localhost:6006 (should open automatically in browser)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
add-cashtab-components
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15067
Build 30084: Build Diff
Build 30083: arc lint + arc unit

Event Timeline

majcosta requested changes to this revision.Jan 28 2021, 20:27
majcosta added a subscriber: majcosta.

I recommend using npm ci instead of npm i --legacy-peer-deps, since that'll give you a deterministic build according to the existing package-lock.json which is in the diff already

also, yarn.lock should be deleted, I think?

This revision now requires changes to proceed.Jan 28 2021, 20:27

Delete yarn.lock (bitcoin-abc repo uses npm, not yarn)

majcosta requested changes to this revision.Jan 29 2021, 19:24
majcosta added inline comments.
web/cashtab-components/.gitignore
19 ↗(On Diff #27428)

this probably goes in macOS users $HOME/.gitignore file rather than the repo

26–27 ↗(On Diff #27428)

remove

web/cashtab-components/README.md
3 ↗(On Diff #27428)
25 ↗(On Diff #27428)
This revision now requires changes to proceed.Jan 29 2021, 19:24

README patch, .gitignore remove yarn

This revision is now accepted and ready to land.Feb 1 2021, 18:14