Page MenuHomePhabricator

[Cashtab] Apply BigNumber to all base unit calcs in sendBch
ClosedPublic

Authored by bytesofman on Feb 5 2021, 16:09.

Details

Summary

Finalize the refactor of sendBch function away from toSatoshi methods and js math. Apply BigNumber library to remainder variable and adjust compare functions to use BigNumber methods. Add unit tests to demonstrate no change from previous function.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sendbch-bignumber
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15139
Build 30228: Build Diffcashtab-tests
Build 30227: arc lint + arc unit