Page MenuHomePhabricator
Differential D9444

[refactor] extract function for past activation tests
ClosedPublic
Actions

Authored by majcosta on Apr 23 2021, 16:42.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCd7f5657808e3: [refactor] extract function for past activation tests
Summary

height-based past activation tests use identical code; extract it to a function and call it passing the IsXEnabled function and height as parameters

Test Plan
ninja check

Diff Detail

Event Timeline

majcosta created this revision.Apr 23 2021, 16:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 23 2021, 16:42
majcosta requested review of this revision.Apr 23 2021, 16:42
Harbormaster completed remote builds in B15573: Diff 28265.Apr 23 2021, 16:56
deadalnix requested changes to this revision.Apr 24 2021, 00:04
deadalnix added a subscriber: deadalnix.

Please edit the diff's title and description, right now they are not even proper sentences.

src/test/activation_tests.cpp
43 ↗(On Diff #28265)

Extra new line.

This revision now requires changes to proceed.Apr 24 2021, 00:04
majcosta requested review of this revision.Apr 24 2021, 11:18
majcosta retitled this revision from [refactor] test past activations by height at the same place to [refactor] extract function for past activation tests.
majcosta edited the summary of this revision. (Show Details)
majcosta marked an inline comment as done.
majcosta added inline comments.
src/test/activation_tests.cpp
43 ↗(On Diff #28265)

that line was removed by arc lint, should we change it?

majcosta edited the summary of this revision. (Show Details)Apr 25 2021, 02:36
majcosta edited the summary of this revision. (Show Details)
deadalnix requested changes to this revision.Apr 26 2021, 20:57
deadalnix added inline comments.
src/test/activation_tests.cpp
43 ↗(On Diff #28265)

arc lint doesn't remove new lines between functions.

This revision now requires changes to proceed.Apr 26 2021, 20:57
majcosta updated this revision to Diff 28280.Apr 27 2021, 10:58
majcosta marked an inline comment as done.

corrected missing line between functions, made testPastActivation static

Harbormaster completed remote builds in B15586: Diff 28280.Apr 27 2021, 11:10
deadalnix accepted this revision.Apr 27 2021, 15:17
This revision is now accepted and ready to land.Apr 27 2021, 15:17
Closed by commit rABCd7f5657808e3: [refactor] extract function for past activation tests (authored by majcosta). · Explain WhyApr 27 2021, 15:24
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCd7f5657808e3: [refactor] extract function for past activation tests.

Revision Contents
Changeset List

PathSize
src/
test/
38 lines

Diff 28280

View Options

src/test/activation_tests.cpp

Loading...