Page MenuHomePhabricator

[avalanche] Check the return value of the delegation addLevel() at startup
ClosedPublic

Authored by Fabien on Jun 11 2021, 12:29.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABCcc8b33ed1642: [avalanche] Check the return value of the delegation addLevel() at startup
Summary

Because the key mismatch is already checked, this can only fail if the Schnorr signature fails.
There is no way to trigger this from a test, but in any case we should always check the return to make the init code more robust.

Depends on D9365.

Ref T1635.

Test Plan
ninja check-functional

Diff Detail

Event Timeline

Fabien requested review of this revision.Jun 11 2021, 12:29
Fabien planned changes to this revision.Jun 11 2021, 13:07
Fabien edited the test plan for this revision. (Show Details)

Rebase on top of D9365. The failure case is now unreachable from the tests, but it's still more robust to check the return value.

This revision is now accepted and ready to land.Jun 11 2021, 19:33