Differential D9791

[avalanche] Fix a lock order inversion on shutdown
ClosedPublic
Actions

Authored by Fabien on Jul 15 2021, 09:56.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC3e097cd62491: [avalanche] Fix a lock order inversion on shutdown

Summary

The lock order is touchy during shutdown and was broken by D9768.

Test Plan

With debug:

./test/functional/test_runner.py abc_p2p_proof_inventory

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_fix_inconsistent_lock_order

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16183
Build 32239: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 32238: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 15 2021, 09:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 15 2021, 09:56

Fabien requested review of this revision.Jul 15 2021, 09:56

PiRK accepted this revision.Jul 15 2021, 10:11

This revision is now accepted and ready to land.Jul 15 2021, 10:11

Harbormaster completed remote builds in B16183: Diff 29187.Jul 15 2021, 10:26

Closed by commit rABC3e097cd62491: [avalanche] Fix a lock order inversion on shutdown (authored by Fabien). · Explain WhyJul 15 2021, 10:40

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC3e097cd62491: [avalanche] Fix a lock order inversion on shutdown.

PiRK mentioned this in D9788: Remove mempool global from init.Jul 15 2021, 11:30

PiRK mentioned this in D9789: Remove mempool global from p2p.

PiRK mentioned this in D9790: Remove mempool global.Jul 15 2021, 11:33

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

35 lines

Diff 29187

View Options

[avalanche] Fix a lock order inversion on shutdownClosedPublicActions