Page MenuHomePhabricator

Remove -zapwallettxes
ClosedPublic

Authored by PiRK on Sep 20 2021, 09:24.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC64f1961e185b: Remove -zapwallettxes
Summary

-zapwallettxes is made a hidden option to inform users that it is
removed and they should be using abandontransaction to do the stuck
transaction thing.

This is a backport of core#19671

Test Plan

ninja all check-all

Event Timeline

PiRK requested review of this revision.Sep 20 2021, 09:24
Fabien requested changes to this revision.Sep 20 2021, 12:33
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/init.cpp
139 ↗(On Diff #30065)

It is supposed to move to hidden args

src/wallet/wallet.cpp
4216 ↗(On Diff #30065)

Keep

This revision now requires changes to proceed.Sep 20 2021, 12:33

fix two conflict resolution accidents

PiRK planned changes to this revision.Sep 21 2021, 11:14

Needs rebasing after D10170 is merged

rebase after version bump (hadle conflict in release-notes.md)

This revision is now accepted and ready to land.Sep 21 2021, 17:11
This revision was automatically updated to reflect the committed changes.