Page MenuHomePhabricator

[avalanche] Move the ProofPool definition to its own header
ClosedPublic

Authored by Fabien on Nov 27 2021, 00:06.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABCf8e258013f61: [avalanche] Move the ProofPool definition to its own header
Summary

It will next be turned into a class so we can add methods like addProof and removeProof. There is no change in behavior.

Ref T1854.

Test Plan
ninja all check-avalanche

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Nov 27 2021, 00:06
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/avalanche/proofpool.h
29 ↗(On Diff #31118)

I should have caught up on this, but because you are capturing this, you might as well take by value.

30 ↗(On Diff #31118)

and move here.

This revision is now accepted and ready to land.Nov 29 2021, 22:03