We can use the rejectProof facility for newly invalidated proofs. This avoids a duplicate and makes the code more readable. There is no change in behavior.
Ref T1854.
Depends on D10711.
Details
Details
- Reviewers
tyler-smith - Group Reviewers
Restricted Project - Maniphest Tasks
- Restricted Maniphest Task
- Commits
- rABC42afa7ecdae3: [avalanche] Simplify the updatedBlockTip handler
ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- avalanche_updatedtip_rejectproof
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 17827 Build 35480: Build Diff lint-circular-dependencies · build-diff · build-without-wallet · build-debug · build-clang-tidy · build-clang Build 35479: arc lint + arc unit
Event Timeline
Comment Actions
The iterating over proofs instead of peers looks better, and the removal logic appears correctly deduplicated without change in behavior.