Page MenuHomePhabricator

build: Qt 5.15.2
ClosedPublic

Authored by PiRK on May 22 2023, 07:57.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCb257f040b614: build: Qt 5.15.2
Summary

core#23489

build: xproto 7.0.31

A patch from core#13665 is also needed to make the xproto configure script recognize aarch64.

build: libXau 1.0.9

build: xcb_proto 1.14.1

build: expat 2.4.1

From the PR discussion, about dependencies.md:

Expat is not a direct dependency for the qt package. Why not just remove this line?
Note that we do not mention XCB-only dependencies here.

build: freetype 2.11.0

Co-authored-by: mammix2 <mammix2@hotmail.com>

build: libxcb 1.14

Minimum required libxcb to build qt 5.15.x is 1.11.

https://codereview.qt.nokia.com/c/qt/qtbase/+/253905

Some plugins have been re-enabled as they are required by Qt.

build: add libxcb_util 0.4.0

build: add libxcb_util_render 0.3.9

build: add libxcb_util_keysyms 0.4.0

build: add libxcb_util_image 0.4.0

build: add libxcb_util_wm 0.4.1

Required for xcb_icccm.

build: qt 5.15.2

Notes:

  • I replaced our version of the "fix_numeric_limits" patch with the one from Core, to make future backports easier.

build, qt: Fix regression in rendering on macOS Big Sur


core#23675:

build: Use config_opts instead of passing a compiler flag directly

This approach is safer as it allows the configure script to check the
availability of a compiler flag.


core#24130:

doc: Update the used Qt version


This is a backport of core#23489, core#24130 and core#23675

Depends on D13936

Test Plan

guix build, gitian builds

Diff Detail

Repository
rABC Bitcoin ABC
Branch
qt_mk
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23761
Build 47132: Build Diff
Build 47131: arc lint + arc unit

Event Timeline

@bot gitian-win gitian-linux gitian-osx

Tail of the build log:

 * [new tag]             phabricator/diff/40208 -> phabricator/diff/40208
 * [new tag]             phabricator/diff/40210 -> phabricator/diff/40210
 * [new tag]             phabricator/diff/40214 -> phabricator/diff/40214
 * [new tag]             phabricator/diff/40231 -> phabricator/diff/40231
 * [new tag]             phabricator/diff/40233 -> phabricator/diff/40233
 * [new tag]             phabricator/diff/40235 -> phabricator/diff/40235
 * [new tag]             phabricator/diff/40244 -> phabricator/diff/40244
 * [new tag]             phabricator/diff/40245 -> phabricator/diff/40245
 * [new tag]             phabricator/diff/40246 -> phabricator/diff/40246
 * [new tag]             phabricator/diff/40247 -> phabricator/diff/40247
 * [new tag]             phabricator/diff/40249 -> phabricator/diff/40249
 * [new tag]             phabricator/diff/40253 -> phabricator/diff/40253
 * [new tag]             phabricator/diff/40255 -> phabricator/diff/40255
 * [new tag]             phabricator/diff/40258 -> phabricator/diff/40258
 * [new tag]             phabricator/diff/40274 -> phabricator/diff/40274
 * [new tag]             phabricator/diff/40275 -> phabricator/diff/40275
 * [new tag]             phabricator/diff/40276 -> phabricator/diff/40276
 * [new tag]             phabricator/diff/40278 -> phabricator/diff/40278
 * [new tag]             phabricator/diff/40279 -> phabricator/diff/40279
 * [new tag]             phabricator/diff/40281 -> phabricator/diff/40281
 * [new tag]             phabricator/diff/40285 -> phabricator/diff/40285
 * [new tag]             phabricator/diff/40286 -> phabricator/diff/40286
 * [new tag]             phabricator/diff/40292 -> phabricator/diff/40292
 * [new tag]             phabricator/diff/40295 -> phabricator/diff/40295
 * [new tag]             phabricator/diff/40326 -> phabricator/diff/40326
 * [new tag]             phabricator/diff/40327 -> phabricator/diff/40327
 * [new tag]             phabricator/diff/40334 -> phabricator/diff/40334
 * [new tag]             phabricator/diff/40339 -> phabricator/diff/40339
 * [new tag]             phabricator/diff/40340 -> phabricator/diff/40340
 * [new tag]             phabricator/diff/40365 -> phabricator/diff/40365
 * [new tag]             phabricator/diff/40366 -> phabricator/diff/40366
 * [new tag]             phabricator/diff/40367 -> phabricator/diff/40367
 * [new tag]             phabricator/diff/40368 -> phabricator/diff/40368
 * [new tag]             phabricator/diff/40373 -> phabricator/diff/40373
 * [new tag]             phabricator/diff/40375 -> phabricator/diff/40375
 * [new tag]             phabricator/diff/8992  -> phabricator/diff/8992
 * [new tag]             phabricator/diff/8993  -> phabricator/diff/8993
 * [new branch]          master                 -> master
--- Building for bullseye amd64 ---
Stopping target if it is up
Error response from daemon: No such container: gitian-target
Error: No such container: gitian-target
Making a new image copy
Starting target
Checking if target is up.
Preparing build environment
Updating apt-get repository (log in var/install.log)
Installing additional packages (log in var/install.log)
Upgrading system, may take a while (log in var/install.log)
Creating package manifest
Creating build script (var/build-script)
Running build script (log in var/build.log)
./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
	from ./bin/gbuild:185:in `build_one_configuration'
	from ./bin/gbuild:339:in `block (2 levels) in <main>'
	from ./bin/gbuild:334:in `each'
	from ./bin/gbuild:334:in `block in <main>'
	from ./bin/gbuild:332:in `each'
	from ./bin/gbuild:332:in `<main>'
Build gitian-linux failed with exit code 1

Tail of the build log:

 * [new tag]             phabricator/diff/40210 -> phabricator/diff/40210
 * [new tag]             phabricator/diff/40213 -> phabricator/diff/40213
 * [new tag]             phabricator/diff/40215 -> phabricator/diff/40215
 * [new tag]             phabricator/diff/40231 -> phabricator/diff/40231
 * [new tag]             phabricator/diff/40233 -> phabricator/diff/40233
 * [new tag]             phabricator/diff/40247 -> phabricator/diff/40247
 * [new tag]             phabricator/diff/40254 -> phabricator/diff/40254
 * [new tag]             phabricator/diff/40255 -> phabricator/diff/40255
 * [new tag]             phabricator/diff/40258 -> phabricator/diff/40258
 * [new tag]             phabricator/diff/40259 -> phabricator/diff/40259
 * [new tag]             phabricator/diff/40260 -> phabricator/diff/40260
 * [new tag]             phabricator/diff/40274 -> phabricator/diff/40274
 * [new tag]             phabricator/diff/40275 -> phabricator/diff/40275
 * [new tag]             phabricator/diff/40276 -> phabricator/diff/40276
 * [new tag]             phabricator/diff/40277 -> phabricator/diff/40277
 * [new tag]             phabricator/diff/40279 -> phabricator/diff/40279
 * [new tag]             phabricator/diff/40280 -> phabricator/diff/40280
 * [new tag]             phabricator/diff/40281 -> phabricator/diff/40281
 * [new tag]             phabricator/diff/40285 -> phabricator/diff/40285
 * [new tag]             phabricator/diff/40286 -> phabricator/diff/40286
 * [new tag]             phabricator/diff/40290 -> phabricator/diff/40290
 * [new tag]             phabricator/diff/40292 -> phabricator/diff/40292
 * [new tag]             phabricator/diff/40295 -> phabricator/diff/40295
 * [new tag]             phabricator/diff/40310 -> phabricator/diff/40310
 * [new tag]             phabricator/diff/40326 -> phabricator/diff/40326
 * [new tag]             phabricator/diff/40327 -> phabricator/diff/40327
 * [new tag]             phabricator/diff/40330 -> phabricator/diff/40330
 * [new tag]             phabricator/diff/40334 -> phabricator/diff/40334
 * [new tag]             phabricator/diff/40339 -> phabricator/diff/40339
 * [new tag]             phabricator/diff/40340 -> phabricator/diff/40340
 * [new tag]             phabricator/diff/40341 -> phabricator/diff/40341
 * [new tag]             phabricator/diff/40365 -> phabricator/diff/40365
 * [new tag]             phabricator/diff/40366 -> phabricator/diff/40366
 * [new tag]             phabricator/diff/40373 -> phabricator/diff/40373
 * [new tag]             phabricator/diff/40375 -> phabricator/diff/40375
 * [new tag]             phabricator/diff/8992  -> phabricator/diff/8992
 * [new tag]             phabricator/diff/8993  -> phabricator/diff/8993
 * [new branch]          master                 -> master
--- Building for bullseye amd64 ---
Stopping target if it is up
Error response from daemon: No such container: gitian-target
Error: No such container: gitian-target
Making a new image copy
Starting target
Checking if target is up.
Preparing build environment
Updating apt-get repository (log in var/install.log)
Installing additional packages (log in var/install.log)
Upgrading system, may take a while (log in var/install.log)
Creating package manifest
Creating build script (var/build-script)
Running build script (log in var/build.log)
./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
	from ./bin/gbuild:185:in `build_one_configuration'
	from ./bin/gbuild:339:in `block (2 levels) in <main>'
	from ./bin/gbuild:334:in `each'
	from ./bin/gbuild:334:in `block in <main>'
	from ./bin/gbuild:332:in `each'
	from ./bin/gbuild:332:in `<main>'
Build gitian-win failed with exit code 1

Tail of the build log:

 * [new tag]             phabricator/diff/40208 -> phabricator/diff/40208
 * [new tag]             phabricator/diff/40209 -> phabricator/diff/40209
 * [new tag]             phabricator/diff/40210 -> phabricator/diff/40210
 * [new tag]             phabricator/diff/40217 -> phabricator/diff/40217
 * [new tag]             phabricator/diff/40218 -> phabricator/diff/40218
 * [new tag]             phabricator/diff/40229 -> phabricator/diff/40229
 * [new tag]             phabricator/diff/40231 -> phabricator/diff/40231
 * [new tag]             phabricator/diff/40232 -> phabricator/diff/40232
 * [new tag]             phabricator/diff/40233 -> phabricator/diff/40233
 * [new tag]             phabricator/diff/40234 -> phabricator/diff/40234
 * [new tag]             phabricator/diff/40244 -> phabricator/diff/40244
 * [new tag]             phabricator/diff/40245 -> phabricator/diff/40245
 * [new tag]             phabricator/diff/40247 -> phabricator/diff/40247
 * [new tag]             phabricator/diff/40258 -> phabricator/diff/40258
 * [new tag]             phabricator/diff/40276 -> phabricator/diff/40276
 * [new tag]             phabricator/diff/40278 -> phabricator/diff/40278
 * [new tag]             phabricator/diff/40279 -> phabricator/diff/40279
 * [new tag]             phabricator/diff/40280 -> phabricator/diff/40280
 * [new tag]             phabricator/diff/40281 -> phabricator/diff/40281
 * [new tag]             phabricator/diff/40292 -> phabricator/diff/40292
 * [new tag]             phabricator/diff/40293 -> phabricator/diff/40293
 * [new tag]             phabricator/diff/40310 -> phabricator/diff/40310
 * [new tag]             phabricator/diff/40326 -> phabricator/diff/40326
 * [new tag]             phabricator/diff/40327 -> phabricator/diff/40327
 * [new tag]             phabricator/diff/40334 -> phabricator/diff/40334
 * [new tag]             phabricator/diff/40335 -> phabricator/diff/40335
 * [new tag]             phabricator/diff/40339 -> phabricator/diff/40339
 * [new tag]             phabricator/diff/40341 -> phabricator/diff/40341
 * [new tag]             phabricator/diff/40364 -> phabricator/diff/40364
 * [new tag]             phabricator/diff/40365 -> phabricator/diff/40365
 * [new tag]             phabricator/diff/40366 -> phabricator/diff/40366
 * [new tag]             phabricator/diff/40367 -> phabricator/diff/40367
 * [new tag]             phabricator/diff/40368 -> phabricator/diff/40368
 * [new tag]             phabricator/diff/40373 -> phabricator/diff/40373
 * [new tag]             phabricator/diff/40375 -> phabricator/diff/40375
 * [new tag]             phabricator/diff/8992  -> phabricator/diff/8992
 * [new tag]             phabricator/diff/8993  -> phabricator/diff/8993
 * [new branch]          master                 -> master
--- Building for bullseye amd64 ---
Stopping target if it is up
Error response from daemon: No such container: gitian-target
Error: No such container: gitian-target
Making a new image copy
Starting target
Checking if target is up.
Preparing build environment
Updating apt-get repository (log in var/install.log)
Installing additional packages (log in var/install.log)
Upgrading system, may take a while (log in var/install.log)
Creating package manifest
Creating build script (var/build-script)
Running build script (log in var/build.log)
./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
	from ./bin/gbuild:185:in `build_one_configuration'
	from ./bin/gbuild:339:in `block (2 levels) in <main>'
	from ./bin/gbuild:334:in `each'
	from ./bin/gbuild:334:in `block in <main>'
	from ./bin/gbuild:332:in `each'
	from ./bin/gbuild:332:in `<main>'
Build gitian-osx failed with exit code 1
PiRK edited the summary of this revision. (Show Details)

rebase and use parallelism for compiling

@bot gitian-win gitian-osx gitian-linux

Tail of the build log:

 * [new tag]             phabricator/diff/40175 -> phabricator/diff/40175
 * [new tag]             phabricator/diff/40183 -> phabricator/diff/40183
 * [new tag]             phabricator/diff/40187 -> phabricator/diff/40187
 * [new tag]             phabricator/diff/40196 -> phabricator/diff/40196
 * [new tag]             phabricator/diff/40197 -> phabricator/diff/40197
 * [new tag]             phabricator/diff/40200 -> phabricator/diff/40200
 * [new tag]             phabricator/diff/40209 -> phabricator/diff/40209
 * [new tag]             phabricator/diff/40210 -> phabricator/diff/40210
 * [new tag]             phabricator/diff/40231 -> phabricator/diff/40231
 * [new tag]             phabricator/diff/40233 -> phabricator/diff/40233
 * [new tag]             phabricator/diff/40235 -> phabricator/diff/40235
 * [new tag]             phabricator/diff/40245 -> phabricator/diff/40245
 * [new tag]             phabricator/diff/40247 -> phabricator/diff/40247
 * [new tag]             phabricator/diff/40249 -> phabricator/diff/40249
 * [new tag]             phabricator/diff/40254 -> phabricator/diff/40254
 * [new tag]             phabricator/diff/40255 -> phabricator/diff/40255
 * [new tag]             phabricator/diff/40275 -> phabricator/diff/40275
 * [new tag]             phabricator/diff/40276 -> phabricator/diff/40276
 * [new tag]             phabricator/diff/40277 -> phabricator/diff/40277
 * [new tag]             phabricator/diff/40278 -> phabricator/diff/40278
 * [new tag]             phabricator/diff/40279 -> phabricator/diff/40279
 * [new tag]             phabricator/diff/40281 -> phabricator/diff/40281
 * [new tag]             phabricator/diff/40285 -> phabricator/diff/40285
 * [new tag]             phabricator/diff/40310 -> phabricator/diff/40310
 * [new tag]             phabricator/diff/40326 -> phabricator/diff/40326
 * [new tag]             phabricator/diff/40334 -> phabricator/diff/40334
 * [new tag]             phabricator/diff/40335 -> phabricator/diff/40335
 * [new tag]             phabricator/diff/40340 -> phabricator/diff/40340
 * [new tag]             phabricator/diff/40341 -> phabricator/diff/40341
 * [new tag]             phabricator/diff/40365 -> phabricator/diff/40365
 * [new tag]             phabricator/diff/40366 -> phabricator/diff/40366
 * [new tag]             phabricator/diff/40367 -> phabricator/diff/40367
 * [new tag]             phabricator/diff/40368 -> phabricator/diff/40368
 * [new tag]             phabricator/diff/40377 -> phabricator/diff/40377
 * [new tag]             phabricator/diff/40379 -> phabricator/diff/40379
 * [new tag]             phabricator/diff/40380 -> phabricator/diff/40380
 * [new tag]             phabricator/diff/40382 -> phabricator/diff/40382
 * [new tag]             phabricator/diff/8992  -> phabricator/diff/8992
 * [new tag]             phabricator/diff/8993  -> phabricator/diff/8993
 * [new branch]          master                 -> master
--- Building for bullseye amd64 ---
Stopping target if it is up
Making a new image copy
Starting target
Checking if target is up.
Preparing build environment
Updating apt-get repository (log in var/install.log)
Installing additional packages (log in var/install.log)
Upgrading system, may take a while (log in var/install.log)
Creating package manifest
Creating build script (var/build-script)
Running build script (log in var/build.log)
./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
	from ./bin/gbuild:185:in `build_one_configuration'
	from ./bin/gbuild:339:in `block (2 levels) in <main>'
	from ./bin/gbuild:334:in `each'
	from ./bin/gbuild:334:in `block in <main>'
	from ./bin/gbuild:332:in `each'
	from ./bin/gbuild:332:in `<main>'
Build gitian-linux failed with exit code 1

Tail of the build log:

 * [new tag]             phabricator/diff/40163 -> phabricator/diff/40163
 * [new tag]             phabricator/diff/40164 -> phabricator/diff/40164
 * [new tag]             phabricator/diff/40175 -> phabricator/diff/40175
 * [new tag]             phabricator/diff/40177 -> phabricator/diff/40177
 * [new tag]             phabricator/diff/40183 -> phabricator/diff/40183
 * [new tag]             phabricator/diff/40187 -> phabricator/diff/40187
 * [new tag]             phabricator/diff/40194 -> phabricator/diff/40194
 * [new tag]             phabricator/diff/40196 -> phabricator/diff/40196
 * [new tag]             phabricator/diff/40197 -> phabricator/diff/40197
 * [new tag]             phabricator/diff/40200 -> phabricator/diff/40200
 * [new tag]             phabricator/diff/40209 -> phabricator/diff/40209
 * [new tag]             phabricator/diff/40210 -> phabricator/diff/40210
 * [new tag]             phabricator/diff/40233 -> phabricator/diff/40233
 * [new tag]             phabricator/diff/40244 -> phabricator/diff/40244
 * [new tag]             phabricator/diff/40245 -> phabricator/diff/40245
 * [new tag]             phabricator/diff/40246 -> phabricator/diff/40246
 * [new tag]             phabricator/diff/40247 -> phabricator/diff/40247
 * [new tag]             phabricator/diff/40249 -> phabricator/diff/40249
 * [new tag]             phabricator/diff/40253 -> phabricator/diff/40253
 * [new tag]             phabricator/diff/40254 -> phabricator/diff/40254
 * [new tag]             phabricator/diff/40258 -> phabricator/diff/40258
 * [new tag]             phabricator/diff/40285 -> phabricator/diff/40285
 * [new tag]             phabricator/diff/40286 -> phabricator/diff/40286
 * [new tag]             phabricator/diff/40292 -> phabricator/diff/40292
 * [new tag]             phabricator/diff/40295 -> phabricator/diff/40295
 * [new tag]             phabricator/diff/40310 -> phabricator/diff/40310
 * [new tag]             phabricator/diff/40327 -> phabricator/diff/40327
 * [new tag]             phabricator/diff/40334 -> phabricator/diff/40334
 * [new tag]             phabricator/diff/40335 -> phabricator/diff/40335
 * [new tag]             phabricator/diff/40340 -> phabricator/diff/40340
 * [new tag]             phabricator/diff/40341 -> phabricator/diff/40341
 * [new tag]             phabricator/diff/40377 -> phabricator/diff/40377
 * [new tag]             phabricator/diff/40379 -> phabricator/diff/40379
 * [new tag]             phabricator/diff/40380 -> phabricator/diff/40380
 * [new tag]             phabricator/diff/40382 -> phabricator/diff/40382
 * [new tag]             phabricator/diff/8992  -> phabricator/diff/8992
 * [new tag]             phabricator/diff/8993  -> phabricator/diff/8993
 * [new branch]          master                 -> master
--- Building for bullseye amd64 ---
Stopping target if it is up
Error response from daemon: No such container: gitian-target
Error: No such container: gitian-target
Making a new image copy
Starting target
Checking if target is up.
Preparing build environment
Updating apt-get repository (log in var/install.log)
Installing additional packages (log in var/install.log)
Upgrading system, may take a while (log in var/install.log)
Creating package manifest
Creating build script (var/build-script)
Running build script (log in var/build.log)
./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
	from ./bin/gbuild:185:in `build_one_configuration'
	from ./bin/gbuild:339:in `block (2 levels) in <main>'
	from ./bin/gbuild:334:in `each'
	from ./bin/gbuild:334:in `block in <main>'
	from ./bin/gbuild:332:in `each'
	from ./bin/gbuild:332:in `<main>'
Build gitian-osx failed with exit code 1

It fails for aarc64-linux-gnu:

Extracting xproto...
/home/debian/cache/common/xproto-7.0.31.tar.bz2: OK
Preprocessing xproto...
Configuring xproto...
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
/home/debian/build/bitcoin/depends/work/build/aarch64-linux-gnu/xproto/7.0.31-bba7c4efb34/missing: Unknown `--is-lightweight' option
Try `/home/debian/build/bitcoin/depends/work/build/aarch64-linux-gnu/xproto/7.0.31-bba7c4efb34/missing --help' for more information
configure: WARNING: 'missing' script is too old or missing
checking for aarch64-linux-gnu-strip... aarch64-linux-gnu-strip
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... no
checking for mawk... mawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking for style of include used by make... GNU
checking for aarch64-linux-gnu-gcc... aarch64-linux-gnu-gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... yes
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether aarch64-linux-gnu-gcc accepts -g... yes
checking for aarch64-linux-gnu-gcc option to accept ISO C89... none needed
checking whether aarch64-linux-gnu-gcc understands -c and -o together... yes
checking dependency style of aarch64-linux-gnu-gcc... none
checking for aarch64-linux-gnu-gcc option to accept ISO C99... none needed
checking how to run the C preprocessor... aarch64-linux-gnu-gcc -E
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking whether __clang__ is declared... no
checking whether __INTEL_COMPILER is declared... no
checking whether __SUNPRO_C is declared... no
checking for aarch64-linux-gnu-pkg-config... no
checking for pkg-config... /usr/bin/pkg-config
configure: WARNING: using cross tools not prefixed with host triplet
checking pkg-config is at least version 0.9.0... yes
checking build system type... x86_64-unknown-linux-gnu
checking host system type... Invalid configuration `aarch64-linux-gnu': machine `aarch64' not recognized
configure: error: /bin/bash ./config.sub aarch64-linux-gnu failed

I can reproduce this on my local machine with HOST=aarch64-linux-gnu make qt

And for Mac OS:

[6/6] Running symbol-check.py on bitcoin-qt...
FAILED: src/qt/CMakeFiles/symbol-check-bitcoin-qt 
cd /home/debian/build/bitcoin/distsrc-x86_64-apple-darwin19/src/qt && /usr/bin/python3.9 /home/debian/build/bitcoin/contrib/devtools/symbol-check.py /home/debian/build/bitcoin/distsrc-x86_64-apple-darwin19/src/qt/BitcoinABC-Qt.app/Contents/MacOS/BitcoinABC-Qt
GSS is not in ALLOWED_LIBRARIES!
/home/debian/build/bitcoin/distsrc-x86_64-apple-darwin19/src/qt/BitcoinABC-Qt.app/Contents/MacOS/BitcoinABC-Qt: failed DYNAMIC_LIBRARIES
ninja: build stopped: subcommand failed.

allow libgssapi_krb5.so.2 for MacOS symbol check

PiRK edited the summary of this revision. (Show Details)

fix aarch64 support for xproto

@bot gitian-win gitian-osx gitian-linux

Tail of the build log:

 * [new tag]             phabricator/diff/40183 -> phabricator/diff/40183
 * [new tag]             phabricator/diff/40187 -> phabricator/diff/40187
 * [new tag]             phabricator/diff/40196 -> phabricator/diff/40196
 * [new tag]             phabricator/diff/40197 -> phabricator/diff/40197
 * [new tag]             phabricator/diff/40200 -> phabricator/diff/40200
 * [new tag]             phabricator/diff/40209 -> phabricator/diff/40209
 * [new tag]             phabricator/diff/40210 -> phabricator/diff/40210
 * [new tag]             phabricator/diff/40231 -> phabricator/diff/40231
 * [new tag]             phabricator/diff/40233 -> phabricator/diff/40233
 * [new tag]             phabricator/diff/40235 -> phabricator/diff/40235
 * [new tag]             phabricator/diff/40245 -> phabricator/diff/40245
 * [new tag]             phabricator/diff/40247 -> phabricator/diff/40247
 * [new tag]             phabricator/diff/40249 -> phabricator/diff/40249
 * [new tag]             phabricator/diff/40254 -> phabricator/diff/40254
 * [new tag]             phabricator/diff/40255 -> phabricator/diff/40255
 * [new tag]             phabricator/diff/40275 -> phabricator/diff/40275
 * [new tag]             phabricator/diff/40276 -> phabricator/diff/40276
 * [new tag]             phabricator/diff/40277 -> phabricator/diff/40277
 * [new tag]             phabricator/diff/40278 -> phabricator/diff/40278
 * [new tag]             phabricator/diff/40279 -> phabricator/diff/40279
 * [new tag]             phabricator/diff/40281 -> phabricator/diff/40281
 * [new tag]             phabricator/diff/40285 -> phabricator/diff/40285
 * [new tag]             phabricator/diff/40310 -> phabricator/diff/40310
 * [new tag]             phabricator/diff/40326 -> phabricator/diff/40326
 * [new tag]             phabricator/diff/40334 -> phabricator/diff/40334
 * [new tag]             phabricator/diff/40335 -> phabricator/diff/40335
 * [new tag]             phabricator/diff/40340 -> phabricator/diff/40340
 * [new tag]             phabricator/diff/40341 -> phabricator/diff/40341
 * [new tag]             phabricator/diff/40365 -> phabricator/diff/40365
 * [new tag]             phabricator/diff/40366 -> phabricator/diff/40366
 * [new tag]             phabricator/diff/40367 -> phabricator/diff/40367
 * [new tag]             phabricator/diff/40368 -> phabricator/diff/40368
 * [new tag]             phabricator/diff/40377 -> phabricator/diff/40377
 * [new tag]             phabricator/diff/40379 -> phabricator/diff/40379
 * [new tag]             phabricator/diff/40380 -> phabricator/diff/40380
 * [new tag]             phabricator/diff/40382 -> phabricator/diff/40382
 * [new tag]             phabricator/diff/40384 -> phabricator/diff/40384
 * [new tag]             phabricator/diff/8992  -> phabricator/diff/8992
 * [new tag]             phabricator/diff/8993  -> phabricator/diff/8993
 * [new branch]          master                 -> master
--- Building for bullseye amd64 ---
Stopping target if it is up
Making a new image copy
Starting target
Checking if target is up.
Preparing build environment
Updating apt-get repository (log in var/install.log)
Installing additional packages (log in var/install.log)
Upgrading system, may take a while (log in var/install.log)
Creating package manifest
Creating build script (var/build-script)
Running build script (log in var/build.log)
./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
	from ./bin/gbuild:185:in `build_one_configuration'
	from ./bin/gbuild:339:in `block (2 levels) in <main>'
	from ./bin/gbuild:334:in `each'
	from ./bin/gbuild:334:in `block in <main>'
	from ./bin/gbuild:332:in `each'
	from ./bin/gbuild:332:in `<main>'
Build gitian-osx failed with exit code 1

Tail of the build log:

 * [new tag]             phabricator/diff/40286 -> phabricator/diff/40286
 * [new tag]             phabricator/diff/40292 -> phabricator/diff/40292
 * [new tag]             phabricator/diff/40293 -> phabricator/diff/40293
 * [new tag]             phabricator/diff/40295 -> phabricator/diff/40295
 * [new tag]             phabricator/diff/40310 -> phabricator/diff/40310
 * [new tag]             phabricator/diff/40311 -> phabricator/diff/40311
 * [new tag]             phabricator/diff/40316 -> phabricator/diff/40316
 * [new tag]             phabricator/diff/40317 -> phabricator/diff/40317
 * [new tag]             phabricator/diff/40318 -> phabricator/diff/40318
 * [new tag]             phabricator/diff/40319 -> phabricator/diff/40319
 * [new tag]             phabricator/diff/40321 -> phabricator/diff/40321
 * [new tag]             phabricator/diff/40322 -> phabricator/diff/40322
 * [new tag]             phabricator/diff/40326 -> phabricator/diff/40326
 * [new tag]             phabricator/diff/40327 -> phabricator/diff/40327
 * [new tag]             phabricator/diff/40329 -> phabricator/diff/40329
 * [new tag]             phabricator/diff/40334 -> phabricator/diff/40334
 * [new tag]             phabricator/diff/40339 -> phabricator/diff/40339
 * [new tag]             phabricator/diff/40340 -> phabricator/diff/40340
 * [new tag]             phabricator/diff/40341 -> phabricator/diff/40341
 * [new tag]             phabricator/diff/40345 -> phabricator/diff/40345
 * [new tag]             phabricator/diff/40346 -> phabricator/diff/40346
 * [new tag]             phabricator/diff/40351 -> phabricator/diff/40351
 * [new tag]             phabricator/diff/40354 -> phabricator/diff/40354
 * [new tag]             phabricator/diff/40356 -> phabricator/diff/40356
 * [new tag]             phabricator/diff/40361 -> phabricator/diff/40361
 * [new tag]             phabricator/diff/40362 -> phabricator/diff/40362
 * [new tag]             phabricator/diff/40365 -> phabricator/diff/40365
 * [new tag]             phabricator/diff/40366 -> phabricator/diff/40366
 * [new tag]             phabricator/diff/40367 -> phabricator/diff/40367
 * [new tag]             phabricator/diff/40368 -> phabricator/diff/40368
 * [new tag]             phabricator/diff/40377 -> phabricator/diff/40377
 * [new tag]             phabricator/diff/40379 -> phabricator/diff/40379
 * [new tag]             phabricator/diff/40380 -> phabricator/diff/40380
 * [new tag]             phabricator/diff/40381 -> phabricator/diff/40381
 * [new tag]             phabricator/diff/40385 -> phabricator/diff/40385
 * [new tag]             phabricator/diff/8992  -> phabricator/diff/8992
 * [new tag]             phabricator/diff/8993  -> phabricator/diff/8993
 * [new branch]          master                 -> master
--- Building for bullseye amd64 ---
Stopping target if it is up
Error response from daemon: No such container: gitian-target
Error: No such container: gitian-target
Making a new image copy
Starting target
Checking if target is up.
Preparing build environment
Updating apt-get repository (log in var/install.log)
Installing additional packages (log in var/install.log)
Upgrading system, may take a while (log in var/install.log)
Creating package manifest
Creating build script (var/build-script)
Running build script (log in var/build.log)
./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
	from ./bin/gbuild:185:in `build_one_configuration'
	from ./bin/gbuild:339:in `block (2 levels) in <main>'
	from ./bin/gbuild:334:in `each'
	from ./bin/gbuild:334:in `block in <main>'
	from ./bin/gbuild:332:in `each'
	from ./bin/gbuild:332:in `<main>'
Build gitian-osx failed with exit code 1
PiRK edited the summary of this revision. (Show Details)

rebase

rebase, drop unrequired feature and allow GSS lib on Mac OS

@bot gitian-osx gitian-win gitian-linux

PiRK published this revision for review.May 24 2023, 11:49
Fabien requested changes to this revision.May 24 2023, 16:12
Fabien added a subscriber: Fabien.
Fabien added inline comments.
depends/packages/qt.mk
15 ↗(On Diff #40404)

we are missing the fix_montery_include.patch

90 ↗(On Diff #40404)

where does this come from?

195 ↗(On Diff #40404)

That's not from these PRs

depends/packages/xproto.mk
14 ↗(On Diff #40404)

Where does this change come from ?

depends/patches/qt/fix_limits_header.patch
1 ↗(On Diff #40404)

This is not added in this PR

This revision now requires changes to proceed.May 24 2023, 16:12
depends/packages/qt.mk
15 ↗(On Diff #40404)

This is one of the patches that seems specific to ARM64 osx. I can add it.

195 ↗(On Diff #40404)

We fixed this issue separately with a similar patch. In this backport i decided to replace our patch with the one from Core, to make future backports easier and avoid having to update our patch.

depends/packages/xproto.mk
14 ↗(On Diff #40404)

I added a comment about this in the description (the one about . core#13665). It is necessary for aarch64 support, and it comes from a backport we didn't grab because Core added it for riscv support.

depends/patches/qt/fix_limits_header.patch
1 ↗(On Diff #40404)

See reply above.

depends/packages/qt.mk
15 ↗(On Diff #40404)

It will be hard to figure out what's missing when we add support for ARM64 osx, let's add it as it doesn't hurt

195 ↗(On Diff #40404)

OK

depends/packages/xproto.mk
14 ↗(On Diff #40404)

OK

depends/packages/qt.mk
90 ↗(On Diff #40404)

That's a separate PR. I removed it. I was testing which additional features can be disabled and forgot to remove it.

rebase after dependencies, update a patch that is now part of this PR

@bot gitian-win gitian-osx gitian-linux

PiRK edited the summary of this revision. (Show Details)
Fabien requested changes to this revision.May 25 2023, 20:04
Fabien added inline comments.
depends/packages/qt.mk
90 ↗(On Diff #40429)

It's still here ?

This revision now requires changes to proceed.May 25 2023, 20:04
PiRK edited the summary of this revision. (Show Details)

remove it for real

This revision is now accepted and ready to land.May 26 2023, 12:40
This revision was automatically updated to reflect the committed changes.