Page MenuHomePhabricator
Differential D1532

Make comments in abandonconflict legible.
ClosedPublic
Actions

Authored by schancel on Jul 2 2018, 23:43.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGfee84fb954d8: Make comments in abandonconflict legible.
rABCfee84fb954d8: Make comments in abandonconflict legible.
Summary

Per title

Test Plan
NA

Diff Detail

Repository
rABC Bitcoin ABC
Branch
nits
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2789
Build 3688: Bitcoin ABC Buildbot (legacy)
Build 3687: arc lint + arc unit

Event Timeline

schancel created this revision.Jul 2 2018, 23:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 2 2018, 23:43
teamcity added a subscriber: teamcity.Jul 2 2018, 23:43

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

schancel updated this revision to Diff 4188.Jul 2 2018, 23:44

Fix a comment

teamcity added a comment.Jul 2 2018, 23:44

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

jasonbcox requested changes to this revision.Jul 2 2018, 23:57
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
test/functional/abandonconflict.py
95

Transactino -> Transaction

98

Please add a note either here or far before this comment that indicates that the wallet and mempool do not have to be in sync. This is a very strange concept in my opinion and deserves its own documentation.

123

Can you clarify the first sentence here? Does this imply that an abandoned tx is the exact same thing as a tx that is not in the mempool? If there are differences between these, please make that explicit. At the moment, it sounds like an abandon tx may be a subclass of not-in-mempool transactions?

This revision now requires changes to proceed.Jul 2 2018, 23:57
teamcity added a comment.Jul 3 2018, 00:16

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2788: Diff 4187!Jul 3 2018, 00:16
teamcity added a comment.Jul 3 2018, 00:18

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2789: Diff 4188!Jul 3 2018, 00:18
schancel updated this revision to Diff 4189.Jul 3 2018, 01:30

Reword a few things

teamcity added a comment.Jul 3 2018, 01:31

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 3 2018, 02:07

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2790: Diff 4189!Jul 3 2018, 02:07
jasonbcox accepted this revision.Jul 3 2018, 02:44
This revision is now accepted and ready to land.Jul 3 2018, 02:44
Closed by commit rABCfee84fb954d8: Make comments in abandonconflict legible. (authored by schancel). · Explain WhyJul 3 2018, 14:46
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
test/
functional/
30 lines

Diff 4188

View Options

test/functional/abandonconflict.py

Loading...