Page MenuHomePhabricator

Move function checking encoding of public key and signature out of interpreter.{h/cpp}
ClosedPublic

Authored by deadalnix on Jul 14 2018, 19:23.

Details

Summary

This improves modularity and will allow for more targeted testing.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sigencoding
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2879
Build 3862: Bitcoin ABC Buildbot (legacy)
Build 3861: arc lint + arc unit

Event Timeline

Mengerian requested changes to this revision.Jul 15 2018, 20:04
Mengerian added a subscriber: Mengerian.
Mengerian added inline comments.
src/script/script_flags.h
1 ↗(On Diff #4304)

Minor nit: Probably good to carry over the "Satoshi Nakamoto" and "Bitcoin Core Developers" copyrights also.

src/script/sigencoding.cpp
1 ↗(On Diff #4304)

carry over Satoshi and Core copyright notices.

src/script/sigencoding.h
1 ↗(On Diff #4304)

Same here, carry over Satoshi and Core copyright notices.

This revision now requires changes to proceed.Jul 15 2018, 20:04
This revision is now accepted and ready to land.Jul 16 2018, 15:33
This revision was automatically updated to reflect the committed changes.