Page MenuHomePhabricator

[Cashtab] Replace balances object with balanceSats number
AbandonedPublicDraft

Authored by bytesofman on Jan 30 2024, 04:20.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

Now that we have better wallet helper functions, replace the balances object with the simple balanceSats number

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
balance-sats-not-obj
Lint
Lint Errors
SeverityLocationCodeMessage
Errorcashtab/src/hooks/useWallet.js:10ESLINTno-unused-vars
Errorcashtab/src/hooks/useWallet.js:21ESLINTno-unused-vars
Unit
No Test Coverage
Build Status
Buildable 26738
Build 53044: Build Diffcashtab-tests
Build 53043: arc lint + arc unit

Event Timeline

Tail of the build log:

/work/cashtab /work/abc-ci-builds/cashtab-tests

added 1930 packages, and audited 1931 packages in 41s

264 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

> cashtab@1.0.8 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

[eslint] 
src/hooks/useWallet.js
  Line 10:5:  'getWalletBalanceFromUtxos' is defined but never used  no-unused-vars
  Line 21:5:  'xecReceivedNotification' is defined but never used    no-unused-vars

Search for the keywords to learn more about each error.


Build cashtab-tests failed with exit code 1

implemented elsewhere