Page MenuHomePhabricator
Differential D18379

[Cashtab] Patch send button overflow issue
ClosedPublic
Actions

Authored by bytesofman on Jul 16 2025, 16:21.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCefd57c97e999: [Cashtab] Patch send button overflow issue
Summary

T3841

Seeing the send button overflow on Firefox

Add more specific css conditions to prevent this

Test Plan

npm start and it looks ok, see screenshots

can check this version deployed to cashtab.io

image.png (870×1 px, 90 KB)

build extension, test with pop-ups, confirm this still looks as before with "Accept" and "Reject" buttons visible even for large txs

Diff Detail

Repository
rABC Bitcoin ABC
Branch
patch-button-css
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33899
Build 67268: Build Diffcashtab-tests
Build 67267: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jul 16 2025, 16:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 16 2025, 16:21
bytesofman edited the test plan for this revision. (Show Details)Jul 16 2025, 16:24
bytesofman published this revision for review.Jul 16 2025, 16:26
Harbormaster completed remote builds in B33898: Diff 54887.Jul 16 2025, 16:26
bytesofman updated this revision to Diff 54888.Jul 16 2025, 17:25

use a more robust approach, also bump extension since we need to test this does not mess with extension pop-up view

bytesofman edited the test plan for this revision. (Show Details)Jul 16 2025, 17:26
Harbormaster completed remote builds in B33899: Diff 54888.Jul 16 2025, 17:30
johnkuney added a subscriber: johnkuney.Jul 16 2025, 17:36
johnkuney added inline comments.
cashtab/src/components/Send/SendXec.tsx
90

if you bump this a bit it gets rid of the scroll bar

bytesofman marked an inline comment as done.Jul 16 2025, 19:31
bytesofman updated this revision to Diff 54889.Jul 16 2025, 19:31

reduce min-height values to prevent scroll on mobile and desktop

Harbormaster completed remote builds in B33900: Diff 54889.Jul 16 2025, 19:35
Fabien accepted this revision.Jul 16 2025, 19:43
This revision is now accepted and ready to land.Jul 16 2025, 19:43
Closed by commit rABCefd57c97e999: [Cashtab] Patch send button overflow issue (authored by bytesofman). · Explain WhyJul 16 2025, 19:46
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCefd57c97e999: [Cashtab] Patch send button overflow issue.

Revision Contents
Changeset List

PathSize
cashtab/
extension/
public/
2 lines
4 lines
2 lines
src/
components/
Send/
7 lines
27 lines

Diff 54888

View Options

cashtab/extension/public/manifest.json

Loading...
View Options

cashtab/package-lock.json

Loading...
View Options

cashtab/package.json

Loading...
View Options

cashtab/src/components/Send/SendXec.tsx

Loading...
View Options

cashtab/src/components/Send/styled.ts

Loading...