Paths

Table of Contentst

Differential D18824

Only support 32-byte keys in ChaCha20{,Aligned}
ClosedPublic
Actions

Authored by PiRK on Wed, Oct 22, 09:53.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC1727b37ad00b: Only support 32-byte keys in ChaCha20{,Aligned}

Summary

This is a partial backport of core#26153
https://github.com/bitcoin/bitcoin/pull/26153/commits/62ec713961ade7b58e90c905395558a41e8a59f0
Depends on D18823

Test Plan

ninja all check-all bench-bitcoin bitcoin-fuzzers

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34848
Build 69158: Build Diff	lint-circular-dependencies · build-without-wallet · build-fuzzer · build-diff · build-debug · build-clang-tidy · build-clang · build-bench
Build 69157: arc lint + arc unit

Event Timeline

PiRK created this revision.Wed, Oct 22, 09:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Oct 22, 09:53

PiRK requested review of this revision.Wed, Oct 22, 09:53

teamcity edited the summary of this revision. (Show Details)Wed, Oct 22, 09:53

Harbormaster completed remote builds in B34848: Diff 56264.Wed, Oct 22, 10:46

Fabien accepted this revision.Thu, Oct 23, 13:09

This revision is now accepted and ready to land.Thu, Oct 23, 13:09

Closed by commit rABC1727b37ad00b: Only support 32-byte keys in ChaCha20{,Aligned} (authored by Pieter Wuille <pieter@wuille.net>, committed by PiRK). · Explain WhyThu, Oct 23, 17:41

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC1727b37ad00b: Only support 32-byte keys in ChaCha20{,Aligned}.

Revision Contents
Changeset List

Path

Size

src/

bench/

chacha20.cpp

2 lines

crypto/

18 lines

33 lines

5 lines

3 lines

6 lines

test/

crypto_tests.cpp

11 lines

fuzz/

crypto_chacha20.cpp

19 lines

Diff 56264

View Options

src/bench/chacha20.cpp

View Options

src/crypto/chacha20.h

View Options

src/crypto/chacha20.cpp

View Options

src/crypto/chacha_poly_aead.cpp

View Options

src/crypto/muhash.cpp

View Options

src/random.cpp

View Options

src/test/crypto_tests.cpp

View Options

src/test/fuzz/crypto_chacha20.cpp

Only support 32-byte keys in ChaCha20{,Aligned}ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 56264

src/bench/chacha20.cpp

src/crypto/chacha20.h

src/crypto/chacha20.cpp

src/crypto/chacha_poly_aead.cpp

src/crypto/muhash.cpp

src/random.cpp

src/test/crypto_tests.cpp

src/test/fuzz/crypto_chacha20.cpp

Only support 32-byte keys in ChaCha20{,Aligned}
ClosedPublic
Actions

Revision Contents
Changeset List