[ecash-wallet] Patch ts issue to stay consistent with defined interface
ClosedPublic
Actions

Authored by bytesofman on Mon, Oct 27, 16:24.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC949c0978ce79: [ecash-wallet] Patch ts issue to stay consistent with defined interface

Summary

If an app uses ecash-wallet as a dep and has strict type checking, it will throw an error on this.

Properly speaking we only want to have a missingTokens key if there are missing tokens; we do not really want missingTokens: undefined

Patch.

Test Plan

npm test and CI tests

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ts-patch-wallet

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34875
Build 69212: Build Diff	ecash-wallet-integration-tests · ecash-wallet-tests · ecash-agora-integration-tests · cashtab-faucet-tests
Build 69211: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mon, Oct 27, 16:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Oct 27, 16:24

Harbormaster completed remote builds in B34875: Diff 56313.Mon, Oct 27, 17:04

bytesofman published this revision for review.Mon, Oct 27, 17:11

Fabien accepted this revision.Mon, Oct 27, 17:19

This revision is now accepted and ready to land.Mon, Oct 27, 17:19

Closed by commit rABC949c0978ce79: [ecash-wallet] Patch ts issue to stay consistent with defined interface (authored by bytesofman). · Explain WhyMon, Oct 27, 17:27

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC949c0978ce79: [ecash-wallet] Patch ts issue to stay consistent with defined interface.

Revision Contents
Changeset List

Path

Size

modules/

ecash-wallet/

src/

wallet.ts

11 lines

Diff 56313

View Options

modules/ecash-wallet/src/wallet.ts

[ecash-wallet] Patch ts issue to stay consistent with defined interfaceClosedPublicActions