Differential D18886

log: rate limiting followups
ClosedPublic
Actions

Authored by Fabien on Wed, Nov 5, 22:04.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCf1f3f1b879cc: log: rate limiting followups

Summary

Followups to #32604.

There are two behavior changes:

    prefixing with [*] is done to all logs (regardless of should_ratelimit) per this comment.
    a DEBUG_ONLY -disableratelimitlogging flag is added by default to functional tests so they don't encounter rate limiting.

Backport of core#33011.

Depends on D18885.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR33011

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34986
Build 69434: Build Diff	lint-circular-dependencies · build-diff · build-clang-tidy · build-debug · build-clang · build-without-wallet
Build 69433: arc lint + arc unit

Event Timeline

Fabien created this revision.Wed, Nov 5, 22:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Nov 5, 22:04

Fabien requested review of this revision.Wed, Nov 5, 22:04

teamcity edited the summary of this revision. (Show Details)Wed, Nov 5, 22:04

Fabien added a child revision: D18887: test: don't throw from the destructor of DebugLogHelper.Wed, Nov 5, 22:13

Harbormaster completed remote builds in B34986: Diff 56471.Wed, Nov 5, 22:24

PiRK added a subscriber: PiRK.Thu, Nov 6, 07:44

PiRK added inline comments.

src/test/logging_tests.cpp
55	This line is not changed in the PR. There should just be one line added to the end

Add back unintentionally removed line

Harbormaster completed remote builds in B34991: Diff 56479.Thu, Nov 6, 08:41

PiRK accepted this revision.Thu, Nov 6, 09:21

This revision is now accepted and ready to land.Thu, Nov 6, 09:21

Closed by commit rABCf1f3f1b879cc: log: rate limiting followups (authored by Eugene Siegel <elzeigel@gmail.com>, committed by Fabien). · Explain WhyThu, Nov 6, 09:45

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf1f3f1b879cc: log: rate limiting followups.

Revision Contents
Changeset List

Path

Size

src/

14 lines

init/

6 lines

86 lines

65 lines

test/

logging_tests.cpp

356 lines

util/

1 line

test/

functional/

test_framework/

1 line

Diff 56471

src/init.cpp

Loading...

src/init/common.cpp

Loading...

src/logging.h

Loading...

src/logging.cpp

Loading...

src/test/logging_tests.cpp

Loading...

src/test/util/logging.h

Loading...

test/functional/test_framework/test_node.py

Loading...