test: fix constructor of msg_tx
ClosedPublic
Actions

Authored by PiRK on Thu, Nov 6, 17:04.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCdc73a3e11b56: test: fix constructor of msg_tx

Summary

In python, if the default value is a mutable object
its shared over all instances, so that one instance being changed
would affect others to be changed as well.
This was likely the source of various intermittent bugs in the
functional tests.

This is a backport of core#30552

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr30552

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35001
Build 69463: Build Diff	build-clang-tidy · build-debug · build-without-wallet · build-clang · build-diff
Build 69462: arc lint + arc unit

Event Timeline

PiRK created this revision.Thu, Nov 6, 17:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Nov 6, 17:04

PiRK requested review of this revision.Thu, Nov 6, 17:04

teamcity edited the summary of this revision. (Show Details)Thu, Nov 6, 17:04

We fixed some of these issues with D7910 with some regex catching lists, dicts or set literals. But this is insufficient.

We might want to backport core#30553 for a more generic solution catching other type of mutable default args. This would add a new linter (ruff), but according to the doc it has drop-in parity with black and flake8, so maybe a net win in the end.

Harbormaster completed remote builds in B35001: Diff 56499.Thu, Nov 6, 17:23

Fabien accepted this revision.Thu, Nov 6, 20:16

This revision is now accepted and ready to land.Thu, Nov 6, 20:16

Closed by commit rABCdc73a3e11b56: test: fix constructor of msg_tx (authored by Martin Zumsande <mzumsande@gmail.com>, committed by PiRK). · Explain WhyFri, Nov 7, 08:59

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCdc73a3e11b56: test: fix constructor of msg_tx.

PiRK mentioned this in D18904: [lint] switch from Black to Ruff for python code formatting.Fri, Nov 7, 14:55

PiRK mentioned this in rABC14fa79a95013: [lint] switch from Black to Ruff for python code formatting.Mon, Nov 10, 15:27