Page MenuHomePhabricator

Update release notes to include several missing items
ClosedPublic

Authored by schancel on Nov 1 2018, 02:39.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
release-notes
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3772
Build 5618: Bitcoin ABC Buildbot (legacy)
Build 5617: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Nov 1 2018, 14:01
Fabien added a subscriber: Fabien.
Fabien added inline comments.
doc/release-notes.md
15 ↗(On Diff #5613)

Should be moved to new "Backports from Bitcoin Core" section

This revision now requires changes to proceed.Nov 1 2018, 14:01
doc/release-notes.md
11 ↗(On Diff #5620)

The existence of this section is being discussed in D1986

jasonbcox added inline comments.
doc/release-notes.md
11 ↗(On Diff #5620)

From that discussion, it seems a little valuable to just list this as RPC backports from Core: and move the non-RPC comments up above. Thoughts?

doc/release-notes.md
11 ↗(On Diff #5620)

From my point of view, this release note is not consistent enough to spend much time sorting it with categories. Furthermore "RPC backports" has a narrow scope. We can later discuss a template if the release notes are expected to be significantly larger.

deadalnix requested changes to this revision.Nov 4 2018, 12:52
This revision now requires changes to proceed.Nov 4 2018, 12:52
Fabien requested changes to this revision.Nov 5 2018, 23:01
This revision now requires changes to proceed.Nov 5 2018, 23:01
doc/release-notes.md
19

Duplicated line

This revision is now accepted and ready to land.Nov 5 2018, 23:17
This revision was automatically updated to reflect the committed changes.