Paths

Table of Contentst

Differential D18920

[ecash-wallet] Do not add unnecessary postage
ClosedPublic
Actions

Authored by bytesofman on Tue, Nov 11, 20:23.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC5bcbe1cdfe12: [ecash-wallet] Do not add unnecessary postage

Summary

It's possible a tx built with the NO_SATS strategy and intended for postage does not actually need it. We should check for this before we start to add fuel utxos.

Test Plan

npm test, CI

Diff Detail

Repository

rABC Bitcoin ABC

Branch

check-postage

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35042
Build 69544: Build Diff	cashtab-faucet-tests · ecash-wallet-integration-tests · ecash-agora-integration-tests · ecash-wallet-tests
Build 69543: arc lint + arc unit

Event Timeline

bytesofman created this revision.Tue, Nov 11, 20:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Nov 11, 20:23

bytesofman published this revision for review.Tue, Nov 11, 20:24

Harbormaster completed remote builds in B35042: Diff 56566.Tue, Nov 11, 20:37

Fabien accepted this revision.Tue, Nov 11, 20:38

This revision is now accepted and ready to land.Tue, Nov 11, 20:38

Closed by commit rABC5bcbe1cdfe12: [ecash-wallet] Do not add unnecessary postage (authored by bytesofman). · Explain WhyTue, Nov 11, 20:42

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC5bcbe1cdfe12: [ecash-wallet] Do not add unnecessary postage.

Revision Contents
Changeset List

Path

Size

modules/

ecash-wallet/

6 lines

package-lock.json

4 lines

2 lines

src/

76 lines

test/

postage.test.ts

188 lines

Diff 56566

modules/ecash-wallet/README.md

Loading...

modules/ecash-wallet/package-lock.json

Loading...

modules/ecash-wallet/package.json

Loading...

modules/ecash-wallet/src/wallet.ts

Loading...

modules/ecash-wallet/test/postage.test.ts

Loading...