Page MenuHomePhabricator
Differential D18929

test: ensure reason is checked for invalid blocks rejection
ClosedPublic
Actions

Authored by PiRK on Thu, Nov 13, 17:14.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC95386e73f188: test: ensure reason is checked for invalid blocks rejection
Summary

This concludes backport of core#32591
https://github.com/bitcoin/bitcoin/pull/32591/commits/8fcd6845052354fad80ae7e5feda3f6a2e441e12
Depends on D18928

Test Plan

test/functional/test_runner.py feature_block p2p_invalid_tx

Diff Detail

Event Timeline

PiRK created this revision.Thu, Nov 13, 17:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Nov 13, 17:14
PiRK requested review of this revision.Thu, Nov 13, 17:14
teamcity edited the summary of this revision. (Show Details)Thu, Nov 13, 17:14
PiRK added a child revision: D18930: [test] A non-standard transaction which is also consensus-invalid should return the consensus error.Thu, Nov 13, 17:19
Harbormaster completed remote builds in B35055: Diff 56586.Thu, Nov 13, 17:34
Fabien accepted this revision.Fri, Nov 14, 10:07
This revision is now accepted and ready to land.Fri, Nov 14, 10:07
Fabien requested changes to this revision.Fri, Nov 14, 10:07

The test plan is not covering the change

This revision now requires changes to proceed.Fri, Nov 14, 10:07
Fabien mentioned this in D18930: [test] A non-standard transaction which is also consensus-invalid should return the consensus error.Fri, Nov 14, 10:08
PiRK requested review of this revision.Fri, Nov 14, 11:10
PiRK edited the test plan for this revision. (Show Details)
PiRK edited the test plan for this revision. (Show Details)Fri, Nov 14, 11:40
Fabien accepted this revision.Fri, Nov 14, 12:08
This revision is now accepted and ready to land.Fri, Nov 14, 12:08
Closed by commit rABC95386e73f188: test: ensure reason is checked for invalid blocks rejection (authored by Greg Sanders <gsanders87@gmail.com>, committed by PiRK). · Explain WhyFri, Nov 14, 12:16
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC95386e73f188: test: ensure reason is checked for invalid blocks rejection.

Revision Contents
Changeset List

PathSize
test/
functional/
data/
4 lines
2 lines

Diff 56586

View Options

test/functional/data/invalid_txs.py

Loading...
View Options

test/functional/feature_block.py

Loading...