Page MenuHomePhabricator
Differential D18931

[Cashtab] Add a script to build a signed release
ClosedPublic
Actions

Authored by bytesofman on Thu, Nov 13, 22:29.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC4cbd4b5ad909: [Cashtab] Add a script to build a signed release
Summary

Add a script with README instructions for building a signed prod release

Test Plan

./build-android-release.sh ... though it only works if you also follow the readme instructions and create the key and the properties file

Diff Detail

Repository
rABC Bitcoin ABC
Branch
publish-cashtab-android
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 35057
Build 69574: Build Diffcashtab-tests
Build 69573: arc lint + arc unit

Event Timeline

bytesofman created this revision.Thu, Nov 13, 22:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Nov 13, 22:29
bytesofman published this revision for review.Thu, Nov 13, 22:30
Harbormaster completed remote builds in B35057: Diff 56588.Thu, Nov 13, 22:38
bytesofman updated this revision to Diff 56589.Fri, Nov 14, 00:26

readme AI sanitize

Harbormaster completed remote builds in B35058: Diff 56589.Fri, Nov 14, 00:35
Fabien requested changes to this revision.Fri, Nov 14, 09:56
Fabien added a subscriber: Fabien.
Fabien added inline comments.
cashtab/build-android-release.sh
1 ↗(On Diff #56589)

Add a copyright header

8 ↗(On Diff #56589)

then popd at the end of the script so you don't move the current working dir without noticing the user (makes automation much easier)

42 ↗(On Diff #56589)

You should make that an argument of the script instead, so it can be used in a non interactive environment

This revision now requires changes to proceed.Fri, Nov 14, 09:56
bytesofman marked 3 inline comments as done.Fri, Nov 14, 13:04
bytesofman added inline comments.
cashtab/build-android-release.sh
42 ↗(On Diff #56589)

apparently this is what we really want to upload to the play store, so changed to just have it do this by default

bytesofman updated this revision to Diff 56602.Fri, Nov 14, 13:06
bytesofman marked an inline comment as done.

improve build script, add header

Harbormaster completed remote builds in B35065: Diff 56602.Fri, Nov 14, 13:36
Fabien accepted this revision.Fri, Nov 14, 13:50
Fabien added inline comments.
cashtab/build-android-release.sh
53 ↗(On Diff #56602)

popd

This revision is now accepted and ready to land.Fri, Nov 14, 13:50
Closed by commit rABC4cbd4b5ad909: [Cashtab] Add a script to build a signed release (authored by bytesofman). · Explain WhyFri, Nov 14, 13:53
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC4cbd4b5ad909: [Cashtab] Add a script to build a signed release.
bytesofman marked an inline comment as done.Fri, Nov 14, 13:53

Revision Contents
Changeset List

PathSize
cashtab/
4 lines
146 lines
android/
5 lines
app/
35 lines
55 lines

Diff 56588

View Options

cashtab/.gitignore

Loading...
View Options

cashtab/README-ANDROID-RELEASE.md

Loading...
View Options

cashtab/android/.gitignore

Loading...
View Options

cashtab/android/app/build.gradle

Loading...
View Options

cashtab/build-android-release.sh

Loading...