Page MenuHomePhabricator

[ecash-wallet] Make sure that no specification of isMintBaton is treated the same as specifying false for isMintBaton
ClosedPublic

Authored by bytesofman on Fri, Nov 14, 00:38.

Details

Summary

Typescript allows token outputs without the isMintBaton key. However, when this happens, the logic is not necessarily parsing this the same as isMintBaton: false

imo it is nice to allow users to not specify isMintBaton since most token send actions do not involve mint batons. But we need to specify isMintBaton: true when something is a mint baton.

Update the logic to reflect this. This corrects a bug where token send atom arrays could be incorrectly calculated if a user forgets to include isMintBaton: false in token outputs that are not mint batons. Otherwise no expected change in behavior.

Test Plan

npm test and CI tests