Page MenuHomePhabricator

[qa] fix abc-p2p-compactblocks test to use add_argument
ClosedPublic

Authored by schancel on Nov 7 2018, 00:10.

Details

Summary

As per title, fixes issue that was introduced with D2010

Test Plan
make && ./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-abc-p2p-test
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3798
Build 5670: Bitcoin ABC Buildbot (legacy)
Build 5669: arc lint + arc unit

Event Timeline

jasonbcox requested changes to this revision.Nov 7 2018, 00:16
jasonbcox added a subscriber: jasonbcox.

I literally just landed D1961 so you'll need to rebase and rename add_options there too. Otherwise, looks good.

This revision now requires changes to proceed.Nov 7 2018, 00:16

Remove add_options change

schancel retitled this revision from [qa] fix abc-p2p-compactblocks test to use add_argument and rename add_options to [qa] fix abc-p2p-compactblocks test to use add_argument.Nov 7 2018, 00:23
This revision is now accepted and ready to land.Nov 7 2018, 00:25
This revision was automatically updated to reflect the committed changes.