Page MenuHomePhabricator

[minig] make CBlockAssembler take a mempool for unit testing.
ClosedPublic

Authored by schancel on Nov 11 2018, 23:10.

Details

Summary

Start passing in mempool into CBlockAssembler for easier unit testing.

Depends on D2058

Test Plan
make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
mempool-injection
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3849
Build 5771: Bitcoin ABC Buildbot (legacy)
Build 5770: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Nov 11 2018, 23:24
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/miner.h
155

It's an horrible name.

Renaming the global mempool in g_mempool should be the first step here.

This revision now requires changes to proceed.Nov 11 2018, 23:24
This revision is now accepted and ready to land.Nov 21 2018, 17:26
This revision was automatically updated to reflect the committed changes.