Differential D2076

Make error message more meaningful when a block contains a duplicate transaction
ClosedPublic
Actions

Authored by deadalnix on Nov 17 2018, 02:37.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING0e31ab2753c0: Make error message more meaningful when a block contains a duplicate transaction
rABC0e31ab2753c0: Make error message more meaningful when a block contains a duplicate transaction

Summary

It also allows to bail early thanks to CTOR.

Test Plan

Added tests cases.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

checkdouble

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3923
Build 5918: Bitcoin ABC Buildbot (legacy)
Build 5917: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 17 2018, 02:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 17 2018, 02:37

Fix typo

Macro lgtm:

This revision is now accepted and ready to land.Nov 17 2018, 02:48

Closed by commit rABC0e31ab2753c0: Make error message more meaningful when a block contains a duplicate transaction (authored by deadalnix). · Explain WhyNov 17 2018, 02:50

This revision was automatically updated to reflect the committed changes.

schancel mentioned this in D2085: [qa] fix p2p-fullblocktest.py to support magnetic anomaly.Nov 18 2018, 08:33

markblundeberg mentioned this in D5081: ConnectBlock: fix slow usage of AddCoins.Jan 27 2020, 17:54

Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rABC1e1a278bdee6: ConnectBlock: fix slow usage of AddCoins.Feb 3 2020, 08:28

Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rSTAGING1e1a278bdee6: ConnectBlock: fix slow usage of AddCoins.Apr 7 2020, 22:46

Revision Contents
Changeset List

Path

Size

src/

test/

uint256_tests.cpp

8 lines

uint256.h

6 lines

validation.cpp

16 lines

test/

functional/

abc-transaction-ordering.py

33 lines

Diff 5848

View Options

src/test/uint256_tests.cpp

View Options

src/uint256.h

View Options

src/validation.cpp

View Options

test/functional/abc-transaction-ordering.py

Make error message more meaningful when a block contains a duplicate transactionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 5848

src/test/uint256_tests.cpp

src/uint256.h

src/validation.cpp

test/functional/abc-transaction-ordering.py

Make error message more meaningful when a block contains a duplicate transaction
ClosedPublic
Actions

Revision Contents
Changeset List