Page MenuHomePhabricator

[qa] fix abc-p2p-fullblock test to support magnetic anomaly
ClosedPublic

Authored by jasonbcox on Nov 18 2018, 09:26.

Details

Summary

Fix failures due to >100 byte tx size requirement, and CTOR.

Test Plan
./test/functional/test_runner.py abc-p2p-fullblocktest

Diff Detail

Repository
rABC Bitcoin ABC
Branch
abc-full-2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3959
Build 5990: Bitcoin ABC Buildbot (legacy)
Build 5989: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Nov 18 2018, 10:26
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/abc-p2p-fullblocktest.py
254 ↗(On Diff #5881)

Please remove

This revision now requires changes to proceed.Nov 18 2018, 10:26
deadalnix added inline comments.
test/functional/abc-p2p-fullblocktest.py
164 ↗(On Diff #5881)

If you need a comment, it means that the function name is not very clear.

make_conform_to_ctor(block)
jasonbcox added a reviewer: schancel.
deadalnix added inline comments.
test/functional/abc-p2p-fullblocktest.py
164 ↗(On Diff #5888)

Put it just before the merkle root hash computation.

Feedback + make_conform_to_ctor from D2085

jasonbcox marked 2 inline comments as done.
jasonbcox removed a reviewer: Fabien.
This revision is now accepted and ready to land.Nov 18 2018, 17:36
This revision was automatically updated to reflect the committed changes.