Page MenuHomePhabricator

[tests] Fix checkinputs_test to work under magnetic anomaly
ClosedPublic

Authored by schancel on Nov 19 2018, 01:34.

Details

Summary

As per title. Add CTOR ordering to test block construction. Use NULLDUMMY
instead of CLEANSTACK for checking consensus vs non-consensus script cache behavior.

Test Plan
make -j10 VERBOSE=1 check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fucked-tests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3977
Build 6026: Bitcoin ABC Buildbot (legacy)
Build 6025: arc lint + arc unit

Event Timeline

schancel created this revision.

Re-remove useless header

deadalnix requested changes to this revision.Nov 19 2018, 01:40
deadalnix added a subscriber: deadalnix.

I'm sure I missed some of the feedback provided on D2089 .

src/test/txvalidationcache_tests.cpp
22 ↗(On Diff #5907)

Remove

182 ↗(On Diff #5907)

Seems like a temporary would be beneficial here

186 ↗(On Diff #5907)

Why is that called p2sh if it is not p2sh ?

194 ↗(On Diff #5907)

The whole block should be scoped

196 ↗(On Diff #5907)

Fix comment

This revision now requires changes to proceed.Nov 19 2018, 01:40
jasonbcox added inline comments.
src/test/txvalidationcache_tests.cpp
249 ↗(On Diff #5907)

DERSIG -> NULLDUMMY

jasonbcox requested changes to this revision.Nov 19 2018, 01:45
jasonbcox requested changes to this revision.Nov 19 2018, 01:56
jasonbcox added inline comments.
src/test/txvalidationcache_tests.cpp
187 ↗(On Diff #5910)

nulldummySigHas -> nulldummySigHash (missing an 'h')

196 ↗(On Diff #5910)

Comment should be // Mine the funding transaction into a block

This revision now requires changes to proceed.Nov 19 2018, 01:56
src/test/txvalidationcache_tests.cpp
170 ↗(On Diff #5910)

double space after Create

src/test/txvalidationcache_tests.cpp
180 ↗(On Diff #5910)

Scope should start before this line imo. There's no reason to have the mutableFunding_tx stuff inside this scope, right?

src/test/txvalidationcache_tests.cpp
180 ↗(On Diff #5910)

It doesn't change anything. But it groups things logically. Ehter way it is fine.

This revision is now accepted and ready to land.Nov 19 2018, 02:01
This revision was automatically updated to reflect the committed changes.