Page MenuHomePhabricator

[avalanche] Add a facility to select invs to poll
ClosedPublic

Authored by deadalnix on Nov 11 2018, 15:38.

Details

Summary

This extends the AvalancheProcessor with facility to decide what to poll.

Depends on D2043

Test Plan

Added unit tests.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
producefinalized
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4020
Build 6111: Bitcoin ABC Buildbot (legacy)
Build 6110: arc lint + arc unit

Event Timeline

deadalnix changed the visibility from "Public (No Login Required)" to "Restricted Project (Project)".Nov 11 2018, 17:29

addBlockToReconciliate => addBlockToReconcile

jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/avalanche.cpp
65 ↗(On Diff #5751)

Does this need a static_assert() to ensure it's strictly less than MAX_INV_SZ?

This revision is now accepted and ready to land.Nov 11 2018, 23:33
jasonbcox requested changes to this revision.Nov 13 2018, 03:43
jasonbcox added inline comments.
src/avalanche.cpp
65 ↗(On Diff #5751)

The more I look at the other changes, the more important I think this is. Either strictly less than MAX_INV_SZ or dependent on MAX_PROTOCOL_MESSAGE_LENGTH in some way.

This revision now requires changes to proceed.Nov 13 2018, 03:43
deadalnix marked an inline comment as done.
deadalnix added inline comments.
src/avalanche.cpp
65 ↗(On Diff #5751)

No. This is fast protocol, we want a low limit.

src/avalanche.cpp
65 ↗(On Diff #5751)

Ok, as long as we expect it to always be way lower.

deadalnix changed the visibility from "Restricted Project (Project)" to "Public (No Login Required)".Nov 21 2018, 13:28
This revision is now accepted and ready to land.Nov 22 2018, 18:59
This revision was automatically updated to reflect the committed changes.