Page MenuHomePhabricator

Record when a block was fully received and checked
AbandonedPublic

Authored by schancel on Nov 26 2018, 23:14.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

As per title. This potentially enables punishment for block withholding as per Jonathan Toomim's ideas.

Test Plan
make VERBOSE=1 check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-D2128
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4136
Build 6343: Bitcoin ABC Buildbot (legacy)
Build 6342: arc lint + arc unit

Event Timeline

schancel edited the summary of this revision. (Show Details)

Add missing sections

deadalnix requested changes to this revision.Nov 26 2018, 23:44
deadalnix added inline comments.
src/validation.cpp
3845

This method is there to do all the bookeeping happening once a block is found. It belongs in there.

This revision now requires changes to proceed.Nov 26 2018, 23:44
schancel added inline comments.
src/validation.cpp
3845

@deadalnix Okay, thank you. Will fix.

src/chain.h
143 ↗(On Diff #6132)

This clearly conflicts with the goals of D2131