Page MenuHomePhabricator
Differential D2151

Use sys.exit(...) instead of exit(...): exit(...) should not be used in programs
ClosedPublic
Actions

Authored by jasonbcox on Nov 30 2018, 00:02.

Details

Reviewers
deadalnix
schancel
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGe5662f0b544a: Use sys.exit(...) instead of exit(...): exit(...) should not be used in programs
rABCe5662f0b544a: Use sys.exit(...) instead of exit(...): exit(...) should not be used in programs
Summary

Backport 3-of-6 for Core PR10781
T473
Depends on D2150

Test Plan

N/A as these scripts are not used. This is a dependency for other backports.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10781-3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4180
Build 6426: Bitcoin ABC Buildbot (legacy)
Build 6425: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Nov 30 2018, 00:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2018, 00:02
teamcity added a subscriber: teamcity.Nov 30 2018, 00:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B4180: Diff 6185!Nov 30 2018, 00:14
teamcity added a comment.Nov 30 2018, 00:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

schancel accepted this revision.Nov 30 2018, 05:32
This revision is now accepted and ready to land.Nov 30 2018, 05:32
jasonbcox added a child revision: D2166: Remove unused variables and/or function calls.Dec 1 2018, 00:04
Fabien accepted this revision.Dec 6 2018, 07:32
teamcity added a comment.Dec 10 2018, 01:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4180: Diff 6185.Dec 10 2018, 01:17
teamcity added a comment.Dec 10 2018, 01:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABCe5662f0b544a: Use sys.exit(...) instead of exit(...): exit(...) should not be used in programs (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by jasonbcox). · Explain WhyDec 10 2018, 02:29
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
contrib/
devtools/
3 lines
2 lines
2 lines
4 lines
linearize/
2 lines
seeds/
share/
qt/
2 lines

Diff 6185

View Options

contrib/devtools/check-doc.py

Loading...
View Options

contrib/devtools/security-check.py

Loading...
View Options

contrib/devtools/symbol-check.py

Loading...
View Options

contrib/devtools/update-translations.py

Loading...
View Options

contrib/linearize/linearize-hashes.py

Loading...
View Options

contrib/seeds/generate-seeds.py

Loading...
View Options

share/qt/extract_strings_qt.py

Loading...