Page MenuHomePhabricator

[net] Ignore getheaders requests for very old side blocks
ClosedPublic

Authored by Fabien on Dec 27 2018, 21:56.

Details

Summary

Sending a getheaders message with an empty locator and a stop hash
is a request for a single header by hash. The node will respond with
headers for blocks not in the main chain as well as those in the main
chain. To avoid fingerprinting, the node should, however, ignore
requests for headers on side branches that are too old.

Backport of core PR11113

Test Plan
./test/functional/test_runner.py p2p-fingerprint

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D2226
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4412
Build 6889: Bitcoin ABC Buildbot (legacy)
Build 6888: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Dec 30 2018, 12:30
Fabien planned changes to this revision.Dec 30 2018, 13:56

Needs an entry in the timings.json file

This revision is now accepted and ready to land.Jan 4 2019, 18:46
Fabien requested review of this revision.Jan 4 2019, 18:47
This revision is now accepted and ready to land.Jan 6 2019, 02:27
This revision was automatically updated to reflect the committed changes.