Page MenuHomePhabricator

[CMAKE] Fix cmake check-functional dependencies
ClosedPublic

Authored by Fabien on Feb 4 2019, 15:54.

Details

Summary

test_runner.py does not need bitcoin-test-util.py to run, but requires bitcoin-cli for some tests.

Test Plan

Run:

cmake -DBUILD_BITCOIN_CLI=OFF -GNinja .. && ninja check-functional

It should return:
ninja: error: '../src/bitcoin-cli', needed by 'test/CMakeFiles/check-functional', missing and no known rule to make it

Should return no error (clear the cache first):

cmake -GNinja .. && ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_remove_useless_dep
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4867
Build 7797: Bitcoin ABC Buildbot (legacy)
Build 7796: arc lint + arc unit

Event Timeline

Fabien planned changes to this revision.Feb 4 2019, 16:07
Fabien retitled this revision from [CMAKE] Remove useless dependency to bitcoin-test-util for test_runner to [CMAKE] Fix cmake check-functional dependencies.Feb 4 2019, 16:15
Fabien edited the summary of this revision. (Show Details)
Fabien edited the test plan for this revision. (Show Details)

Also add bitcoin-cli dependency

This revision is now accepted and ready to land.Feb 4 2019, 16:36
This revision was automatically updated to reflect the committed changes.