Page MenuHomePhabricator

Fix comment about s in schnorr sigs
ClosedPublic

Authored by florian on Mar 26 2019, 20:32.

Details

Reviewers
markblundeberg
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGc80bf903f979: Fix comment about s in schnorr sigs
rABCc80bf903f979: Fix comment about s in schnorr sigs
Summary

s/order/n/ for consistency.

Test Plan

None

Diff Detail

Repository
rABC Bitcoin ABC
Branch
schnorrcomment
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5322
Build 8706: Bitcoin ABC Buildbot (legacy)
Build 8705: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Mar 26 2019, 20:32
deadalnix requested changes to this revision.Mar 27 2019, 02:00
deadalnix added inline comments.
src/secp256k1/src/modules/schnorr/schnorr_impl.h
31 ↗(On Diff #7837)

It's always mod n, so this is redundant. mod n is required on the previous line because the hash is not a scalar fields element.

This revision now requires changes to proceed.Mar 27 2019, 02:00

Revert the mod n change.

This revision is now accepted and ready to land.Mar 31 2019, 16:55
This revision was automatically updated to reflect the committed changes.