Page MenuHomePhabricator
Differential D1970

[Part 3 of 5] Add a CChainState class to clarify internal interfaces
ClosedPublic
Actions

Authored by schancel on Oct 24 2018, 18:50.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Restricted Owners Package(Owns No Changed Paths)
Commits
rSTAGING20f59d582b2b: [Part 3 of 5] Add a CChainState class to clarify internal interfaces
rABC20f59d582b2b: [Part 3 of 5] Add a CChainState class to clarify internal interfaces
Summary

Make DisconnectBlock unaware of where undo data resides on disk

Backport of core PR 10279 Commit 93a34cf.

Depends on D1969
T572

Test Plan
make VERBOSE=1 check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D1970 (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5334
Build 8730: Bitcoin ABC Buildbot (legacy)
Build 8729: arc lint + arc unit

Event Timeline

schancel created this revision.Oct 24 2018, 18:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 24 2018, 18:50
schancel edited the summary of this revision. (Show Details)Oct 24 2018, 18:52
schancel added a parent revision: D1969: [Part 2 of 5] Add a CChainState class to clarify internal interfaces.
teamcity added a subscriber: teamcity.Oct 24 2018, 18:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel added a child revision: D1971: [Part 4 of 5] Add a CChainState class to clarify internal interfaces.Oct 24 2018, 18:52
teamcity added a comment.Oct 24 2018, 19:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3676: Diff 5525.Oct 24 2018, 19:01
schancel planned changes to this revision.Oct 26 2018, 22:47
schancel updated this revision to Diff 7879.Mar 30 2019, 17:25

Rebase

Owners added a reviewer: Restricted Owners Package.Mar 30 2019, 17:25
teamcity added a comment.Mar 30 2019, 17:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 30 2019, 17:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5334: Diff 7879.Mar 30 2019, 17:40
jasonbcox accepted this revision.Mar 31 2019, 05:23
This revision is now accepted and ready to land.Mar 31 2019, 05:23
Closed by commit rABC20f59d582b2b: [Part 3 of 5] Add a CChainState class to clarify internal interfaces (authored by Matt Corallo <git@bluematt.me>, committed by schancel). · Explain WhyMar 31 2019, 17:53
This revision was automatically updated to reflect the committed changes.
jasonbcox edited the summary of this revision. (Show Details)Apr 2 2019, 20:33
schancel added a commit: rSTAGING20f59d582b2b: [Part 3 of 5] Add a CChainState class to clarify internal interfaces.Sep 19 2019, 14:54

Revision Contents
Changeset List

PathSize
src/
24 lines

Diff 7879

View Options

src/validation.cpp

Loading...