Page MenuHomePhabricator

Format the php files
ClosedPublic

Authored by Fabien on Apr 1 2019, 16:12.

Details

Summary

This is a prerequisite to enforcing a custom phabricator-like coding standard through a linter.

Test Plan

Should run with no exception:

arc lint --everything

Diff Detail

Repository
rABC Bitcoin ABC
Branch
lint_php_files
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5377
Build 8816: Bitcoin ABC Buildbot (legacy)
Build 8815: arc lint + arc unit

Event Timeline

Fabien planned changes to this revision.Apr 1 2019, 19:41

I will define a custom ruleset to make it closer to original's standard.

Update formatting to something close to phabricator standard

deadalnix requested changes to this revision.Apr 3 2019, 20:00
deadalnix added inline comments.
arcanist/linter/AutoPEP8Linter.php
48 ↗(On Diff #7904)

This is quite apparently broken.

This revision now requires changes to proceed.Apr 3 2019, 20:00
Fabien retitled this revision from Format the php files, make them compliant to PSR2 to Format the php files.Apr 4 2019, 06:21
Fabien edited the summary of this revision. (Show Details)

Fix comment alignment

arcanist/linter/AutoPEP8Linter.php
48 ↗(On Diff #7904)

Good catch

deadalnix requested changes to this revision.Apr 4 2019, 15:00
deadalnix added inline comments.
arcanist/linter/TestsLinter.php
140

The indentation is wrong here and all similar patterns.

This revision now requires changes to proceed.Apr 4 2019, 15:00

Indent multiline statements outside of a control block

This revision is now accepted and ready to land.Apr 5 2019, 12:42
This revision was automatically updated to reflect the committed changes.