Page MenuHomePhabricator

Add Sent and Received information to the debug menu peer list
ClosedPublic

Authored by nakihito on Apr 2 2019, 21:55.

Details

Summary

Add Sent and Received information to the debug menu peer list

Backport of Core PR11499
https://github.com/bitcoin/bitcoin/pull/11499

Completes T554

Test Plan

bitcoin-qt
Help -> Debug Window -> Peers should display Sent and Received information

Diff Detail

Repository
rABC Bitcoin ABC
Branch
BackportPR11499
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5467
Build 8996: Bitcoin ABC Buildbot (legacy)
Build 8995: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Apr 2 2019, 21:55

Squashed together two commits.

nakihito requested review of this revision.Apr 9 2019, 19:33
nakihito edited the test plan for this revision. (Show Details)
nakihito edited the test plan for this revision. (Show Details)
jasonbcox requested changes to this revision.Apr 10 2019, 20:24
jasonbcox added inline comments.
src/qt/guiutil.cpp
1008 ↗(On Diff #7925)

All three if-statements needs brackets to match our new codestyle. Many backports do not contain them, but we add them for readability and reduced bug introduction risk.

This revision now requires changes to proceed.Apr 10 2019, 20:24

Added braces {} to if statements. Linter did not catch these for some reason?

Fabien requested changes to this revision.Apr 16 2019, 07:54
Fabien added inline comments.
src/qt/rpcconsole.cpp
1290 ↗(On Diff #8060)

Restore

This revision now requires changes to proceed.Apr 16 2019, 07:54
deadalnix added inline comments.
src/qt/peertablemodel.h
60

trailing coma

This revision is now accepted and ready to land.Apr 18 2019, 15:08

Added trailing comma to ColumnIndex enum.

This revision was automatically updated to reflect the committed changes.