Page MenuHomePhabricator

Remove direct bitcoin calls from qt/utilitydialog.cpp
ClosedPublic

Authored by jasonbcox on Apr 17 2019, 17:12.

Details

Summary
Test Plan
make check
ninja check
bitcoin-qt # sanity checking
bitcoin-qt -help
bitcoin-qt -version

Diff Detail

Repository
rABC Bitcoin ABC
Branch
c4b
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5504
Build 9070: Bitcoin ABC Buildbot (legacy)
Build 9069: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Apr 17 2019, 23:08
deadalnix added inline comments.
src/qt/bitcoin.cpp
652 ↗(On Diff #8101)

You need to check -help and -version as part of your test plan.

This revision now requires changes to proceed.Apr 17 2019, 23:08
jasonbcox edited the test plan for this revision. (Show Details)
jasonbcox marked an inline comment as done.
Fabien requested changes to this revision.Apr 18 2019, 06:13
Fabien added inline comments.
src/qt/utilitydialog.h
14 ↗(On Diff #8101)

You should rename to interfaces: https://github.com/bitcoin/bitcoin/pull/12906

This revision now requires changes to proceed.Apr 18 2019, 06:13
jasonbcox edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Apr 19 2019, 12:50
This revision was automatically updated to reflect the committed changes.