Page MenuHomePhabricator
Differential D2988

Merge #9916: Fix msvc compiler error C4146 (minus operator applied to unsigned type)
ClosedPublic
Actions

Authored by markblundeberg on May 8 2019, 03:01.

Details

Reviewers
jasonbcox
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING3cba26058a56: Merge #9916: Fix msvc compiler error C4146 (minus operator applied to unsigned…
rABC3cba26058a56: Merge #9916: Fix msvc compiler error C4146 (minus operator applied to unsigned…
Summary

backport PR9916 https://github.com/bitcoin/bitcoin/pull/9916/files
8e0720b Fix msvc compiler error C4146 (unary minus operator applied to unsigned type) (kobake)
292112f Fix msvc compiler error C4146 (minus operator applied to unsigned type) (kobake)

Tree-SHA512: 25f408daf7bf9ffe4b8b4bd62f6f6d326219189a9faf8f8c0a135c5a0cb0511af765aa2b6087a091c8863c701289bda49a2379b00cd9b10854d316a5c3fc3f8e

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D2988
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5760
Build 9582: Bitcoin ABC Buildbot (legacy)
Build 9581: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 8 2019, 03:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 8 2019, 03:01
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 8 2019, 03:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 8 2019, 03:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5752: Diff 8496.May 8 2019, 03:16
jasonbcox accepted this revision.May 8 2019, 18:32

Stupid, but I don't want to own this code right now...

This revision is now accepted and ready to land.May 8 2019, 18:32
jasonbcox requested changes to this revision.May 8 2019, 18:33
jasonbcox added inline comments.
src/bloom.cpp
268 ↗(On Diff #8496)

keep the uint64_t(...) style

This revision now requires changes to proceed.May 8 2019, 18:33
markblundeberg updated this revision to Diff 8521.May 8 2019, 18:45

style

teamcity added a comment.May 8 2019, 18:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 8 2019, 18:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5760: Diff 8521.May 8 2019, 18:59
jasonbcox accepted this revision.May 8 2019, 21:28
This revision is now accepted and ready to land.May 8 2019, 21:28
Closed by commit rABC3cba26058a56: Merge #9916: Fix msvc compiler error C4146 (minus operator applied to unsigned… (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 8 2019, 23:19
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING3cba26058a56: Merge #9916: Fix msvc compiler error C4146 (minus operator applied to unsigned….Sep 18 2019, 23:23

Revision Contents
Changeset List

PathSize
src/
4 lines
test/
3 lines

Diff 8521

View Options

src/bloom.cpp

Loading...
View Options

src/test/util_tests.cpp

Loading...