[CMAKE] Add missing files to build bitcoin-qt on OSX
ClosedPublic
Actions

Authored by Fabien on May 13 2019, 10:20.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING863e59f7d7e3: [CMAKE] Add missing files to build bitcoin-qt on OSX
rABC863e59f7d7e3: [CMAKE] Add missing files to build bitcoin-qt on OSX

Summary

The OSX specific files (*.mm) are missing in the OSX build.

Depends on D3032 (for the test plan).

Test Plan

mkdir buildcmake && cd buildcmake
cmake -GNinja -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/OSX.cmake ..
ninja -v

Check the (*.mm) files are part of the build.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.May 13 2019, 10:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 13 2019, 10:20

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D3034: [CMAKE] Disable OpenGL in Qt static build for OSX.May 13 2019, 10:23

Harbormaster completed remote builds in B5829: Diff 8629.May 13 2019, 10:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.May 16 2019, 12:32

This revision is now accepted and ready to land.May 16 2019, 12:32

Closed by commit rABC863e59f7d7e3: [CMAKE] Add missing files to build bitcoin-qt on OSX (authored by Fabien). · Explain WhyMay 17 2019, 20:01

This revision was automatically updated to reflect the committed changes.

Fabien mentioned this in D3018: [CMAKE] Fix CMake cross build for OSX.May 25 2019, 07:15

Fabien added a commit: rSTAGING863e59f7d7e3: [CMAKE] Add missing files to build bitcoin-qt on OSX.Sep 18 2019, 23:36

Revision Contents
Changeset List

Path

Size

src/

qt/

CMakeLists.txt

8 lines

Diff 8724

View Options

[CMAKE] Add missing files to build bitcoin-qt on OSXClosedPublicActions