Page MenuHomePhabricator
Differential D3070

Remove config argument from blockToJSON
ClosedPublic
Actions

Authored by markblundeberg on May 19 2019, 17:26.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGe1039399e967: Remove config argument from blockToJSON
rABCe1039399e967: Remove config argument from blockToJSON
Summary

Was added in "move-only" diff D717.
It is not used anymore since introduction of TxToUniv in D2499.

Depends on D3014

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markblundeberg created this revision.May 19 2019, 17:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 19 2019, 17:26
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 19 2019, 17:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a child revision: D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.May 19 2019, 17:37
Harbormaster completed remote builds in B5895: Diff 8733.May 19 2019, 17:41
teamcity added a comment.May 19 2019, 17:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

markblundeberg mentioned this in D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.May 19 2019, 18:32
Fabien accepted this revision.May 20 2019, 09:00
This revision is now accepted and ready to land.May 20 2019, 09:00
markblundeberg mentioned this in D3073: [RPC] Serialize in getblock without cs_main.May 20 2019, 13:51
Closed by commit rABCe1039399e967: Remove config argument from blockToJSON (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 20 2019, 22:58
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGe1039399e967: Remove config argument from blockToJSON.Sep 18 2019, 23:37

Revision Contents
Changeset List

PathSize
src/
3 lines
rpc/
4 lines
6 lines

Diff 8759

View Options

src/rest.cpp

Loading...
View Options

src/rpc/blockchain.h

Loading...
View Options

src/rpc/blockchain.cpp

Loading...