Page MenuHomePhabricator

Make SCRIPT_DISALLOW_SEGWIT_RECOVERY a standard flag
AbandonedPublic

Authored by Mengerian on May 30 2019, 17:47.

Details

Reviewers
deadalnix
florian
markblundeberg
Fabien
Group Reviewers
Restricted Project
Maniphest Tasks
T653: Clean up past upgrades
Summary

This removes all explicit mention of SCRIPT_DISALLOW_SEGWIT_RECOVERY from validation.cpp

Changes the current behavior by making it impossible to accept segwit recovery transactions
into the mempool, even with -acceptnonstdtxn=1 (this is the same as with all other
script verify flags that are included in standard flags).

Functional test is amended to reflect this change in behavior.

Depends on D3065

Test Plan

make check
./test/functional/test_runner.py
Did IBD with -checkpoints=0 -assumevalid=0

Diff Detail

Repository
rABC Bitcoin ABC
Branch
segwitrecovery-standard-rebase
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6076
Build 10201: Bitcoin ABC Buildbot (legacy)
Build 10200: arc lint + arc unit

Event Timeline

Mengerian edited the summary of this revision. (Show Details)

Add dependency to description.

Mengerian edited the summary of this revision. (Show Details)
Mengerian edited the test plan for this revision. (Show Details)

Update test plan
Improve description
Rebase on D3065

src/validation.cpp
1239 ↗(On Diff #9032)

Ahhh feels good to see this simplification finally. :-D

test/functional/abc-segwit-recovery.py
77 ↗(On Diff #9032)

"...never accepted into the mempool, even when configured to 'accept non-standard transactions'."