Page MenuHomePhabricator
Differential D3290

Move original knapsack solver tests to coinselector_tests.cpp
ClosedPublic
Actions

Authored by deadalnix on Jun 11 2019, 16:54.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING6104bd0dcb40: Move original knapsack solver tests to coinselector_tests.cpp
rABC6104bd0dcb40: Move original knapsack solver tests to coinselector_tests.cpp
Summary

This is a partial backport of Core PR10637 : https://github.com/bitcoin/bitcoin/pull/10637/commits/cd927ff3283fc23a5f42c178e10bcaf5409bb7ea

Depends on D3252 and D3289

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
knapsacktest
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6304
Build 10655: Bitcoin ABC Buildbot (legacy)
Build 10654: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 11 2019, 16:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 11 2019, 16:54
teamcity added a comment.Jun 11 2019, 16:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 11 2019, 17:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6267: Diff 9323.Jun 11 2019, 17:01
Fabien accepted this revision.Jun 12 2019, 12:33
This revision is now accepted and ready to land.Jun 12 2019, 12:33
deadalnix added a child revision: D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.Jun 12 2019, 12:50
deadalnix updated this revision to Diff 9389.Jun 13 2019, 13:08

Rebase

teamcity added a comment.Jun 13 2019, 13:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

This revision was landed with ongoing or failed builds.Jun 13 2019, 13:11
Closed by commit rABC6104bd0dcb40: Move original knapsack solver tests to coinselector_tests.cpp (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC6104bd0dcb40: Move original knapsack solver tests to coinselector_tests.cpp.
teamcity added a comment.Jun 13 2019, 13:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6304: Diff 9389.Jun 13 2019, 13:16
deadalnix added a commit: rSTAGING6104bd0dcb40: Move original knapsack solver tests to coinselector_tests.cpp.Sep 19 2019, 00:17

Revision Contents
Changeset List

PathSize
src/
wallet/
test/
422 lines
437 lines
6 lines

Diff 9389

View Options

src/wallet/test/coinselector_tests.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...