Page MenuHomePhabricator

sigencoding_tests: improve test coverage
ClosedPublic

Authored by markblundeberg on Jun 8 2019, 21:43.

Details

Summary

We weren't checking a huge number of hashtype byte variations for 64-byte
signatures, though some hashtype checks are done in script_tests.

This prepares for adding a Schnorr-only sigencoding checker.

Depends on D3331

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
enctests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6335
Build 10717: Bitcoin ABC Buildbot (legacy)
Build 10716: arc lint + arc unit

Event Timeline

markblundeberg edited the summary of this revision. (Show Details)

rebased onto split-up schnorr removal diffs

This revision is now accepted and ready to land.Jun 25 2019, 20:26