Page MenuHomePhabricator

Merge #10347: Use range-based for loops (C++11) when looping over vector elements
ClosedPublic

Authored by nakihito on Jul 1 2019, 19:58.

Details

Summary

211adc0 Use range-based for loops (C++11) when looping over vector elements (practicalswift)

Tree-SHA512: 0e007f20dcef99d3c7a1036265e00f689d69f42e02fd82dd8389f45b52d31947e5f9388de2610d3d9bd9f554915ce0d35ebce561e5ae3a9013956d0ee4937145

Backport of Core PR10347
https://github.com/bitcoin/bitcoin/pull/10347/files

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR10347
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6603
Build 11253: Bitcoin ABC Buildbot (legacy)
Build 11252: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Jul 1 2019, 19:58
jasonbcox requested changes to this revision.Jul 1 2019, 20:11
jasonbcox added inline comments.
src/wallet/wallet.cpp
2160 ↗(On Diff #9872)

Although we're using range-based loops here, it should still be updated to use auto.

This revision now requires changes to proceed.Jul 1 2019, 20:11
src/wallet/wallet.cpp
2160

Why only doing half the backport ? By replacing in with txin you can remove 4 conflicts.

src/wallet/wallet.cpp
2160 ↗(On Diff #9872)

Because ?

src/wallet/wallet.cpp
2160 ↗(On Diff #9872)

Merge conflict I guess.

nakihito requested review of this revision.Jul 5 2019, 17:55
Fabien added inline comments.
src/wallet/wallet.cpp
2160 ↗(On Diff #9872)

Yes I meant merge conflict.

This revision is now accepted and ready to land.Jul 8 2019, 17:02