Page MenuHomePhabricator
Feed All Stories

Today

emack accepted D16017: [Cashtab] Fix airdrop tx render issue.
Fri, Apr 19, 01:41

Yesterday

bytesofman published D16017: [Cashtab] Fix airdrop tx render issue for review.
Thu, Apr 18, 23:56
teamcity added a comment to D15963: [ecash-lib] Add `TxBuilder` to build Bitcoin transactions.
Thu, Apr 18, 23:38
bytesofman added a comment to D15963: [ecash-lib] Add `TxBuilder` to build Bitcoin transactions.

Ok so remaining punchlist here

Thu, Apr 18, 23:28
tobias_ruck updated the diff for D15963: [ecash-lib] Add `TxBuilder` to build Bitcoin transactions.

fix file casing

Thu, Apr 18, 23:28
tobias_ruck updated the test plan for D15963: [ecash-lib] Add `TxBuilder` to build Bitcoin transactions.
Thu, Apr 18, 23:25
tobias_ruck updated the diff for D15963: [ecash-lib] Add `TxBuilder` to build Bitcoin transactions.

rebase onto master

Thu, Apr 18, 23:21
tobias_ruck closed D15956: [ecash-lib] Add `UnsignedTx` and `UnsignedTxInput`.
Thu, Apr 18, 23:17
tobias_ruck committed rABC07cab0629902: [ecash-lib] Add `UnsignedTx` and `UnsignedTxInput` (authored by tobias_ruck).
[ecash-lib] Add `UnsignedTx` and `UnsignedTxInput`
Thu, Apr 18, 23:17
bytesofman accepted D15956: [ecash-lib] Add `UnsignedTx` and `UnsignedTxInput`.
Thu, Apr 18, 22:53
tobias_ruck added inline comments to D15956: [ecash-lib] Add `UnsignedTx` and `UnsignedTxInput`.
Thu, Apr 18, 22:50
bytesofman published D16012: [Cashtab] Searchable, alphabetical token list for review.
Thu, Apr 18, 22:37
Fabien accepted D16007: Move ::nPruneTarget into BlockManager.
Thu, Apr 18, 19:52
Fabien accepted D15624: validation: Stricter assumeutxo error handling when renaming chainstates.
Thu, Apr 18, 19:52
PiRK updated the diff for D16007: Move ::nPruneTarget into BlockManager.

remove blank line before copyright header

Thu, Apr 18, 19:36
PiRK added a comment to D15624: validation: Stricter assumeutxo error handling when renaming chainstates.

Why do you say there is no change in behavior ? Previously the node would shut down, now it only prints an error. Am I missing something ?

Thu, Apr 18, 19:13
Fabien accepted D16016: Replace pindex pointer with block reference.
Thu, Apr 18, 16:03
Fabien accepted D16015: Add BlockManagerOpts::chainparams reference.
Thu, Apr 18, 16:01
Fabien accepted D16010: refactor: Add and use PRUNE_TARGET_MANUAL constexpr.
Thu, Apr 18, 15:58
Fabien accepted D16009: Pass fImporting to ImportingNow helper class, Move ::fImporting to BlockManager.
Thu, Apr 18, 15:57
Fabien accepted D16008: Move ::fPruneMode into BlockManager.
Thu, Apr 18, 15:56
Fabien requested changes to D16007: Move ::nPruneTarget into BlockManager.
Thu, Apr 18, 15:55
Fabien accepted D16006: Remove reindex special case from the progress bar label.
Thu, Apr 18, 15:50
Fabien added a comment to D15624: validation: Stricter assumeutxo error handling when renaming chainstates.

Why do you say there is no change in behavior ? Previously the node would shut down, now it only prints an error. Am I missing something ?

Thu, Apr 18, 15:47
PiRK updated the diff for D15624: validation: Stricter assumeutxo error handling when renaming chainstates.

rebase

Thu, Apr 18, 14:45
PiRK updated the summary of D16015: Add BlockManagerOpts::chainparams reference.
Thu, Apr 18, 14:34
teamcity updated the summary of D16016: Replace pindex pointer with block reference.
Thu, Apr 18, 14:33
PiRK requested review of D16016: Replace pindex pointer with block reference.
Thu, Apr 18, 14:33
teamcity updated the summary of D16015: Add BlockManagerOpts::chainparams reference.
Thu, Apr 18, 14:32
PiRK requested review of D16015: Add BlockManagerOpts::chainparams reference.
Thu, Apr 18, 14:32
bytesofman closed D16014: [Cashtab] Start reward countdown automatically after claiming rewards.
Thu, Apr 18, 13:29
bytesofman committed rABCd8314b5704b6: [Cashtab] Start reward countdown automatically after claiming rewards (authored by bytesofman).
[Cashtab] Start reward countdown automatically after claiming rewards
Thu, Apr 18, 13:29
emack accepted D16014: [Cashtab] Start reward countdown automatically after claiming rewards.

As per tg chat

Thu, Apr 18, 13:09
bytesofman requested review of D16014: [Cashtab] Start reward countdown automatically after claiming rewards.

The button changes to the timer all ok, and the reward is received all ok as well. However clicking on the received CACHET throws this:

image.png (450×987 px, 95 KB)

Thu, Apr 18, 13:08
emack requested changes to D16014: [Cashtab] Start reward countdown automatically after claiming rewards.

The button changes to the timer all ok, and the reward is received all ok as well. However clicking on the received CACHET throws this:

image.png (450×987 px, 95 KB)

Thu, Apr 18, 13:07
bytesofman published D16014: [Cashtab] Start reward countdown automatically after claiming rewards for review.
Thu, Apr 18, 13:01
bytesofman closed D16013: [token-server] Use ecash-coinselect from npm.
Thu, Apr 18, 12:42
bytesofman committed rABCb271977b7534: [token-server] Use ecash-coinselect from npm (authored by bytesofman).
[token-server] Use ecash-coinselect from npm
Thu, Apr 18, 12:42
emack accepted D16013: [token-server] Use ecash-coinselect from npm.
Thu, Apr 18, 12:41
bytesofman published D16013: [token-server] Use ecash-coinselect from npm for review.
Thu, Apr 18, 12:33
bytesofman closed D15997: [Cashtab + token-server + ecash-coinselect] Implement token rewards for Cashtab users.
Thu, Apr 18, 12:22
bytesofman committed rABC120304164170: [Cashtab + token-server + ecash-coinselect] Implement token rewards for Cashtab… (authored by bytesofman).
[Cashtab + token-server + ecash-coinselect] Implement token rewards for Cashtab…
Thu, Apr 18, 12:22
PiRK closed D16004: validation tests: Use existing {Chainstate,Block}Man.
Thu, Apr 18, 10:02
PiRK committed rABC09ee00dbb2ca: validation tests: Use existing {Chainstate,Block}Man (authored by Carl Dong <contact@carldong.me>).
validation tests: Use existing {Chainstate,Block}Man
Thu, Apr 18, 10:02
emack accepted D15997: [Cashtab + token-server + ecash-coinselect] Implement token rewards for Cashtab users.

Accepted post TG chat

Thu, Apr 18, 05:42
teamcity closed T3549: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Resolved.
Thu, Apr 18, 03:58
bytesofman requested review of D15997: [Cashtab + token-server + ecash-coinselect] Implement token rewards for Cashtab users.
Thu, Apr 18, 03:20
emack requested changes to D15997: [Cashtab + token-server + ecash-coinselect] Implement token rewards for Cashtab users.
Thu, Apr 18, 03:08
bytesofman closed D16011: [Cashtab] Show cursor pointer for extension open in tab button.
Thu, Apr 18, 03:05
bytesofman committed rABCa5cf9ab2059c: [Cashtab] Show cursor pointer for extension open in tab button (authored by bytesofman).
[Cashtab] Show cursor pointer for extension open in tab button
Thu, Apr 18, 03:05
bytesofman closed D16005: [Cashtab] Better validation for token document url.
Thu, Apr 18, 03:04
bytesofman committed rABCe8596237e083: [Cashtab] Better validation for token document url (authored by bytesofman).
[Cashtab] Better validation for token document url
Thu, Apr 18, 03:04
emack accepted D16011: [Cashtab] Show cursor pointer for extension open in tab button.
Thu, Apr 18, 02:34
emack accepted D16005: [Cashtab] Better validation for token document url.
Thu, Apr 18, 02:22

Wed, Apr 17

bytesofman published D16011: [Cashtab] Show cursor pointer for extension open in tab button for review.
Wed, Apr 17, 23:10
bytesofman published D15997: [Cashtab + token-server + ecash-coinselect] Implement token rewards for Cashtab users for review.
Wed, Apr 17, 23:03
bytesofman accepted D16004: validation tests: Use existing {Chainstate,Block}Man.
Wed, Apr 17, 20:32
teamcity updated the summary of D16010: refactor: Add and use PRUNE_TARGET_MANUAL constexpr.
Wed, Apr 17, 20:20
PiRK requested review of D16010: refactor: Add and use PRUNE_TARGET_MANUAL constexpr.
Wed, Apr 17, 20:20
teamcity updated the summary of D16009: Pass fImporting to ImportingNow helper class, Move ::fImporting to BlockManager.
Wed, Apr 17, 20:17
PiRK requested review of D16009: Pass fImporting to ImportingNow helper class, Move ::fImporting to BlockManager.
Wed, Apr 17, 20:16
teamcity updated the summary of D16008: Move ::fPruneMode into BlockManager.
Wed, Apr 17, 20:14
PiRK requested review of D16008: Move ::fPruneMode into BlockManager.
Wed, Apr 17, 20:14
teamcity updated the summary of D16007: Move ::nPruneTarget into BlockManager.
Wed, Apr 17, 20:12
PiRK requested review of D16007: Move ::nPruneTarget into BlockManager.
Wed, Apr 17, 20:12
PiRK updated the diff for D16006: Remove reindex special case from the progress bar label.

no need for the else after the return in the previous if

Wed, Apr 17, 20:03
teamcity updated the summary of D16006: Remove reindex special case from the progress bar label.
Wed, Apr 17, 19:53
PiRK requested review of D16006: Remove reindex special case from the progress bar label.
Wed, Apr 17, 19:53
PiRK added inline comments to D16004: validation tests: Use existing {Chainstate,Block}Man.
Wed, Apr 17, 19:49
bytesofman added inline comments to D16004: validation tests: Use existing {Chainstate,Block}Man.
Wed, Apr 17, 19:42
teamcity triaged T3549: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Unbreak Now! priority.
Wed, Apr 17, 17:35
bytesofman added inline comments to D16000: [Cashtab] Better formdata organization in create token form.
Wed, Apr 17, 16:59
bytesofman published D16005: [Cashtab] Better validation for token document url for review.
Wed, Apr 17, 16:56
bytesofman closed D16001: [Cashtab] Add unimplemented functions to support NFT minting and sending.
Wed, Apr 17, 16:34
bytesofman committed rABCc517e2ea321d: [Cashtab] Add unimplemented functions to support NFT minting and sending (authored by bytesofman).
[Cashtab] Add unimplemented functions to support NFT minting and sending
Wed, Apr 17, 16:34
bytesofman closed D16000: [Cashtab] Better formdata organization in create token form.
Wed, Apr 17, 16:32
bytesofman committed rABC2844d9ce0c0c: [Cashtab] Better formdata organization in create token form (authored by bytesofman).
[Cashtab] Better formdata organization in create token form
Wed, Apr 17, 16:32
bytesofman closed D16002: [Cashtab] Organize styles in own file for Token screen.
Wed, Apr 17, 16:24
bytesofman committed rABCdfe18755ccf9: [Cashtab] Organize styles in own file for Token screen (authored by bytesofman).
[Cashtab] Organize styles in own file for Token screen
Wed, Apr 17, 16:24
bytesofman updated the diff for D16001: [Cashtab] Add unimplemented functions to support NFT minting and sending.

Patch targetOutput generating functions to include dust outputs, add function to get input utxo for nft send tx

Wed, Apr 17, 16:21
bytesofman closed D16003: [Cashtab] Faster transition for opening and closing hamburger menu.
Wed, Apr 17, 15:29
bytesofman committed rABC32ec273a40f5: [Cashtab] Faster transition for opening and closing hamburger menu (authored by bytesofman).
[Cashtab] Faster transition for opening and closing hamburger menu
Wed, Apr 17, 15:29
teamcity updated the summary of D16004: validation tests: Use existing {Chainstate,Block}Man.
Wed, Apr 17, 15:06
PiRK requested review of D16004: validation tests: Use existing {Chainstate,Block}Man.
Wed, Apr 17, 15:06
emack accepted D16001: [Cashtab] Add unimplemented functions to support NFT minting and sending.
Wed, Apr 17, 14:56
emack accepted D16000: [Cashtab] Better formdata organization in create token form.

accepted with minor nits

Wed, Apr 17, 14:47
emack accepted D16003: [Cashtab] Faster transition for opening and closing hamburger menu.
Wed, Apr 17, 14:35
emack accepted D16002: [Cashtab] Organize styles in own file for Token screen.
Wed, Apr 17, 14:30
bytesofman published D16003: [Cashtab] Faster transition for opening and closing hamburger menu for review.
Wed, Apr 17, 13:42
bytesofman published D16002: [Cashtab] Organize styles in own file for Token screen for review.
Wed, Apr 17, 13:35
bytesofman updated the summary of D16000: [Cashtab] Better formdata organization in create token form.
Wed, Apr 17, 13:27
bytesofman updated the diff for D16000: [Cashtab] Better formdata organization in create token form.

rebase

Wed, Apr 17, 13:27
bytesofman closed D15999: [Cashtab] Better organization for create token form.
Wed, Apr 17, 13:26
bytesofman committed rABC2dbda7d608a3: [Cashtab] Better organization for create token form (authored by bytesofman).
[Cashtab] Better organization for create token form
Wed, Apr 17, 13:26
bytesofman closed D15998: [Cashtab] Do not render mint switch on token page unless user has mint baton.
Wed, Apr 17, 13:25
bytesofman committed rABCa656594b8beb: [Cashtab] Do not render mint switch on token page unless user has mint baton (authored by bytesofman).
[Cashtab] Do not render mint switch on token page unless user has mint baton
Wed, Apr 17, 13:25
bytesofman published D16001: [Cashtab] Add unimplemented functions to support NFT minting and sending for review.
Wed, Apr 17, 13:24
bytesofman published D16000: [Cashtab] Better formdata organization in create token form for review.
Wed, Apr 17, 13:23
emack accepted D15999: [Cashtab] Better organization for create token form.
Wed, Apr 17, 13:16
emack accepted D15998: [Cashtab] Do not render mint switch on token page unless user has mint baton.
Wed, Apr 17, 13:13