Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Doing another round of self review and annotating deviations from the original PR.
From the cmake mailing list, this tends to confirm that this property has no impact outside of a windows build: https://cmake.org/pipermail/cmake/2008-March/020577.html
If -deprecatedrpc=fundrawtransaction is set and the reserveChangeKey option is true, you end up removing the key twice.
I discovered by chance that cmake targets have a property which does exactly the same
(setting the exact same flag) in a more cmake fashion way.
This property has no impact if the build is not a windows executable, so no need to
make it explicitely windows only.
Fix bugs in the contrib/convert-prl-libs-to-cmake.pl. This allows for
converting the windows plugin prl script rather than manually linking
getting commit fef5adcc3 looks like it should be done after T590, though it can also wait.
Changed location of deprecation check, removed excess deprecation checks, added new test case.
Also making more changes as recommended by Fabien.
Update tests to match the merged spec (test vectors: V6, V7, I10, I4, I5, I2, I1).
Deprecated -reserveChangeKey option rather than removing it. Changed deprecation comment to reflect next major update. Rebased.
If this diff is revisited, also land D1495