@tobias_ruck Could you change the name to OP_REVERSEBYTES in the Diff title?
It would reverse the metric setting logic as to avoid a double negation. Everything else is good to go.
fixes code comments
remove reverted code
The final revert is done in D4946
rebase from master
Update as per comments
The general approach look good. Obviously, Without changing ScriptExecutionMetrics, it's hard to ensure your invariants hold, so you may want to unpod that guy as well.
Diff updated to address feedback.
The method has changed since the last revision: I added a new option that allow the caller to set a meaningful test suite name and use it in the JUnit output.
Add an option to set the name.
Unhappy tests on my local run (with upgrade activated):
abc-mempool-accept-txn.py | ✖ Failed | 1 s abc-p2p-fullblocktest.py | ✖ Failed | 45 s feature_block.py | ✖ Failed | 62 s
The C++ tests seems to be totally happy, the main issue is dealing with functional tests.
@deadalnix returning for review due to slight changes. Note after our discussion that ScriptExecutionMetrics will remain a pure struct (as it is in this diff) since accumulation etc will happen elsewhere.
remove dependency on D4834