Page MenuHomePhabricator
Feed All Stories

Today

deadalnix requested changes to D4943: Add an option to set the functional test suite name.
Mon, Jan 20, 22:53
deadalnix accepted D5019: CreateNewBlock: insert entries into block slightly earlier so that correct size is logged.
Mon, Jan 20, 22:41
Mengerian added a comment to D4871: Added OP_ENDIAN_REVERSE+implementation, added (always disabled) activation flag, added tests for OP_ENDIAN_REVERSE..

@tobias_ruck Could you change the name to OP_REVERSEBYTES in the Diff title?

Mon, Jan 20, 18:59
deadalnix requested changes to D4940: add a flag that (if unset) zeroes sigchecks reported by VerifyScript.

It would reverse the metric setting logic as to avoid a double negation. Everything else is good to go.

Mon, Jan 20, 18:56
deadalnix requested changes to D4418: Add unit tests for parse_name().
Mon, Jan 20, 18:50
teamcity added a comment to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Jan 20, 17:43
teamcity added a comment to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Jan 20, 17:39
fpelliccioni updated the diff for D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

fixes code comments

Mon, Jan 20, 17:39
teamcity added a comment to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Jan 20, 17:34
teamcity added a comment to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Jan 20, 17:31
teamcity added a comment to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Jan 20, 17:29
fpelliccioni updated the diff for D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

reverted code

Mon, Jan 20, 17:29
fpelliccioni planned changes to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
Mon, Jan 20, 17:27
teamcity added a comment to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Jan 20, 17:27
fpelliccioni updated the diff for D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

remove reverted code

Mon, Jan 20, 17:26
fpelliccioni abandoned D4945: Revert D4942 locking 'time'.

The final revert is done in D4946

Mon, Jan 20, 17:20
teamcity added a comment to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Jan 20, 15:59
teamcity added a comment to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Jan 20, 15:34
fpelliccioni planned changes to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
Mon, Jan 20, 15:34
fpelliccioni updated the diff for D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

rebase from master

Mon, Jan 20, 15:31
Fabien committed rABC98e3d4d14b82: [CMAKE] Get rid of `add_compiler_flags_to_var` (authored by Fabien).
[CMAKE] Get rid of `add_compiler_flags_to_var`
Mon, Jan 20, 15:30
Fabien closed D5002: [CMAKE] Get rid of `add_compiler_flags_to_var`.
Mon, Jan 20, 15:29
Fabien committed rABC8f2432151c56: [CMAKE] Add a check_linker_flag function (authored by Fabien).
[CMAKE] Add a check_linker_flag function
Mon, Jan 20, 15:29
Fabien closed D4961: [CMAKE] Add a check_linker_flag function.
Mon, Jan 20, 15:28
deadalnix committed rABC25dd8a720622: [cmake] Refactor native build cmake generation (authored by deadalnix).
[cmake] Refactor native build cmake generation
Mon, Jan 20, 15:09
deadalnix closed D5026: [cmake] Refactor native build cmake generation.
Mon, Jan 20, 15:09
Fabien accepted D5026: [cmake] Refactor native build cmake generation.
Mon, Jan 20, 15:07
teamcity added a comment to D5026: [cmake] Refactor native build cmake generation.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Jan 20, 14:56
teamcity added a comment to D5026: [cmake] Refactor native build cmake generation.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Jan 20, 14:37
deadalnix updated the diff for D5026: [cmake] Refactor native build cmake generation.

Update as per comments

Mon, Jan 20, 14:37
deadalnix added inline comments to D5026: [cmake] Refactor native build cmake generation.
Mon, Jan 20, 14:35
deadalnix committed rABC3ed9038f912b: [cmake] Do not generate git_ignored_files.txt (authored by deadalnix).
[cmake] Do not generate git_ignored_files.txt
Mon, Jan 20, 14:26
deadalnix closed D5021: [cmake] Do not generate git_ignored_files.txt.
Mon, Jan 20, 14:26
deadalnix requested changes to D5028: [WIP] track per-transaction SigChecks using a TransactionMetricsAccumulator.
Mon, Jan 20, 14:16
deadalnix added a comment to D5028: [WIP] track per-transaction SigChecks using a TransactionMetricsAccumulator.

The general approach look good. Obviously, Without changing ScriptExecutionMetrics, it's hard to ensure your invariants hold, so you may want to unpod that guy as well.

Mon, Jan 20, 14:15
Fabien added a comment to D4943: Add an option to set the functional test suite name.

Diff updated to address feedback.
The method has changed since the last revision: I added a new option that allow the caller to set a meaningful test suite name and use it in the JUnit output.

Mon, Jan 20, 14:07
Fabien requested review of D4943: Add an option to set the functional test suite name.
Mon, Jan 20, 14:05
Fabien updated the summary of D4943: Add an option to set the functional test suite name.
Mon, Jan 20, 14:05
teamcity added a comment to D4943: Add an option to set the functional test suite name.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Jan 20, 13:59
teamcity added a comment to D4943: Add an option to set the functional test suite name.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Jan 20, 13:54
Fabien planned changes to D4943: Add an option to set the functional test suite name.
Mon, Jan 20, 13:54
Fabien updated the diff for D4943: Add an option to set the functional test suite name.

Add an option to set the name.

Mon, Jan 20, 13:54
Fabien retitled D4943: Add an option to set the functional test suite name from Make the test suite name unique in the JUnit result file to Add an option to set the functional test suite name.
Mon, Jan 20, 13:50
Fabien updated the summary of D4943: Add an option to set the functional test suite name.
Mon, Jan 20, 13:49
markblundeberg added a revision to T704: sigChecks implementation: D4941: track ScriptExecutionMetrics in CheckInputs.
Mon, Jan 20, 13:24
markblundeberg added a task to D4941: track ScriptExecutionMetrics in CheckInputs: T704: sigChecks implementation.
Mon, Jan 20, 13:24
markblundeberg added a revision to T704: sigChecks implementation: D5028: [WIP] track per-transaction SigChecks using a TransactionMetricsAccumulator.
Mon, Jan 20, 13:24
markblundeberg added a task to D5028: [WIP] track per-transaction SigChecks using a TransactionMetricsAccumulator: T704: sigChecks implementation.
Mon, Jan 20, 13:24
Fabien planned changes to D4943: Add an option to set the functional test suite name.
Mon, Jan 20, 13:10
Fabien accepted D4807: Add instructions for verifying download integrity against release signer keys.
Mon, Jan 20, 12:39
markblundeberg added a comment to D5029: [wip] deactivate sigops limits in phonon upgrade.

Unhappy tests on my local run (with upgrade activated):

abc-mempool-accept-txn.py               | ✖ Failed  | 1 s
abc-p2p-fullblocktest.py                | ✖ Failed  | 45 s
feature_block.py                        | ✖ Failed  | 62 s
Mon, Jan 20, 12:08
Harbormaster failed remote builds in B9073: Diff 15683 for D5029: [wip] deactivate sigops limits in phonon upgrade!
Mon, Jan 20, 12:03
teamcity added a comment to D5029: [wip] deactivate sigops limits in phonon upgrade.
Mon, Jan 20, 12:03
markblundeberg added inline comments to D5029: [wip] deactivate sigops limits in phonon upgrade.
Mon, Jan 20, 12:01
markblundeberg planned changes to D5029: [wip] deactivate sigops limits in phonon upgrade.

The C++ tests seems to be totally happy, the main issue is dealing with functional tests.

Mon, Jan 20, 11:59
markblundeberg added inline comments to D5029: [wip] deactivate sigops limits in phonon upgrade.
Mon, Jan 20, 11:58
teamcity added a comment to D5029: [wip] deactivate sigops limits in phonon upgrade.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Jan 20, 11:57
markblundeberg created D5029: [wip] deactivate sigops limits in phonon upgrade.
Mon, Jan 20, 11:57
teamcity added a comment to D5026: [cmake] Refactor native build cmake generation.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

Mon, Jan 20, 11:48
teamcity added a comment to D5026: [cmake] Refactor native build cmake generation.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

Mon, Jan 20, 11:47
Fabien requested changes to D5026: [cmake] Refactor native build cmake generation.
Mon, Jan 20, 11:39
teamcity added a comment to D5026: [cmake] Refactor native build cmake generation.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

Mon, Jan 20, 11:39
teamcity added a comment to D5026: [cmake] Refactor native build cmake generation.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

Mon, Jan 20, 11:39
teamcity added a comment to D5026: [cmake] Refactor native build cmake generation.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

Mon, Jan 20, 11:35
teamcity added a comment to D5026: [cmake] Refactor native build cmake generation.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

Mon, Jan 20, 11:35
Fabien accepted D5021: [cmake] Do not generate git_ignored_files.txt.
Mon, Jan 20, 10:51
teamcity added a comment to D5028: [WIP] track per-transaction SigChecks using a TransactionMetricsAccumulator.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Jan 20, 10:35
markblundeberg planned changes to D5028: [WIP] track per-transaction SigChecks using a TransactionMetricsAccumulator.

is wip

Mon, Jan 20, 10:30
markblundeberg retitled D5028: [WIP] track per-transaction SigChecks using a TransactionMetricsAccumulator from track per-transaction SigChecks using a TransactionMetricsAccumulator to [WIP] track per-transaction SigChecks using a TransactionMetricsAccumulator.
Mon, Jan 20, 10:30
teamcity added a comment to D5028: [WIP] track per-transaction SigChecks using a TransactionMetricsAccumulator.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Jan 20, 10:30
markblundeberg created D5028: [WIP] track per-transaction SigChecks using a TransactionMetricsAccumulator.
Mon, Jan 20, 10:29
teamcity added a comment to D4940: add a flag that (if unset) zeroes sigchecks reported by VerifyScript.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Jan 20, 06:19
markblundeberg requested review of D4940: add a flag that (if unset) zeroes sigchecks reported by VerifyScript.

@deadalnix returning for review due to slight changes. Note after our discussion that ScriptExecutionMetrics will remain a pure struct (as it is in this diff) since accumulation etc will happen elsewhere.

Mon, Jan 20, 06:15
teamcity added a comment to D4940: add a flag that (if unset) zeroes sigchecks reported by VerifyScript.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Jan 20, 06:13
markblundeberg updated the diff for D4940: add a flag that (if unset) zeroes sigchecks reported by VerifyScript.

remove dependency on D4834

Mon, Jan 20, 06:13
markblundeberg added inline comments to D4903: Use virtualsize for mining/mempool priority.
Mon, Jan 20, 05:46
markblundeberg added inline comments to D4903: Use virtualsize for mining/mempool priority.
Mon, Jan 20, 04:49
Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABCa11c71c38aee: fix a test in anticipation of SCRIPT_VERIFY_INPUT_SIGCHECKS activation (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).
fix a test in anticipation of SCRIPT_VERIFY_INPUT_SIGCHECKS activation
Mon, Jan 20, 04:20
Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D5016: fix a test in anticipation of SCRIPT_VERIFY_INPUT_SIGCHECKS activation.
Mon, Jan 20, 04:19
Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC70b586dfbdf0: [abc-wallet-standardness] do test the signing error code (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).
[abc-wallet-standardness] do test the signing error code
Mon, Jan 20, 04:18
Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D5017: [abc-wallet-standardness] do test the signing error code.
Mon, Jan 20, 04:18
markblundeberg requested review of D5019: CreateNewBlock: insert entries into block slightly earlier so that correct size is logged.
Mon, Jan 20, 04:16
markblundeberg added inline comments to D5027: always unpark even when -parkdeepreorg=0.
Mon, Jan 20, 04:13
Harbormaster failed remote builds in B9070: Diff 15678 for D5027: always unpark even when -parkdeepreorg=0!
Mon, Jan 20, 04:10
teamcity added a comment to D5027: always unpark even when -parkdeepreorg=0.
Mon, Jan 20, 04:10
markblundeberg planned changes to D5027: always unpark even when -parkdeepreorg=0.
Mon, Jan 20, 04:09
markblundeberg added inline comments to D5027: always unpark even when -parkdeepreorg=0.
Mon, Jan 20, 04:08
markblundeberg added a reviewer for D5027: always unpark even when -parkdeepreorg=0: Fabien.
Mon, Jan 20, 04:08
teamcity added a comment to D5027: always unpark even when -parkdeepreorg=0.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Jan 20, 04:07
markblundeberg created D5027: always unpark even when -parkdeepreorg=0.
Mon, Jan 20, 04:07
markblundeberg added inline comments to D4903: Use virtualsize for mining/mempool priority.
Mon, Jan 20, 00:03

Yesterday

teamcity added a comment to D5026: [cmake] Refactor native build cmake generation.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sun, Jan 19, 22:25
deadalnix accepted D5025: Bump version to 0.20.12.
Sun, Jan 19, 22:09
teamcity added a comment to D5026: [cmake] Refactor native build cmake generation.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sun, Jan 19, 22:08
deadalnix created D5026: [cmake] Refactor native build cmake generation.
Sun, Jan 19, 22:08
teamcity added a comment to D5025: Bump version to 0.20.12.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sun, Jan 19, 20:19
teamcity added a comment to D5025: Bump version to 0.20.12.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sun, Jan 19, 19:58
jasonbcox created D5025: Bump version to 0.20.12.
Sun, Jan 19, 19:32
jasonbcox committed rABCed38fdfc8716: Merge #14494: Error if # is used in rpcpassword in conf (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #14494: Error if # is used in rpcpassword in conf
Sun, Jan 19, 19:26
jasonbcox closed D5012: Merge #14494: Error if # is used in rpcpassword in conf.
Sun, Jan 19, 19:26