Page MenuHomePhabricator
Feed All Stories

Today

D3335: [LINTER] Make the check-doc linter run only once now requires changes to proceed.

I'll need more time to actually review this, but it's clear that the API is not what you'd expect.

Sun, Jun 16, 01:58
teamcity added a comment to D3253: Remove Schnorr activation.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Sun, Jun 16, 01:01
markblundeberg added a comment to D3253: Remove Schnorr activation.

IBD testing done

Sun, Jun 16, 00:57
markblundeberg updated the test plan for D3253: Remove Schnorr activation.
Sun, Jun 16, 00:57
teamcity added a comment to D3253: Remove Schnorr activation.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Sun, Jun 16, 00:53
markblundeberg added a comment to D3253: Remove Schnorr activation.

update per my last comment; we can't properly test 64 byte ECDSA here,
but we can test the multisig length check banning.

Sun, Jun 16, 00:53

Yesterday

D3310: Merge #14085: index: Fix for indexers skipping genesis block. is now accepted and ready to land.
Sat, Jun 15, 23:10
deadalnix accepted D3344: Merge #10999: Fix amounts formatting in `decoderawtransaction`.
Sat, Jun 15, 21:07
D3334: [LINTER] Set the rules for the phpdoc comments is now accepted and ready to land.
Sat, Jun 15, 21:01
D3341: Add benchmark for AES is now accepted and ready to land.
Sat, Jun 15, 21:00
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC9044d3d396df: Merge #14409: utils and libraries: Make 'blocksdir' always net specific (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
Merge #14409: utils and libraries: Make 'blocksdir' always net specific
Sat, Jun 15, 20:16
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.
Sat, Jun 15, 20:16
teamcity added a comment to D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Sat, Jun 15, 19:32
teamcity added a comment to D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Sat, Jun 15, 19:23
markblundeberg added a comment to D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.

rebase pre-land

Sat, Jun 15, 19:23
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCe2c909027fbf: create net-specific data directory early in init process (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
create net-specific data directory early in init process
Sat, Jun 15, 19:20
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3312: create net-specific data directory early in init process.
Sat, Jun 15, 19:20
teamcity added a comment to D3312: create net-specific data directory early in init process.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Sat, Jun 15, 18:21
D3312: create net-specific data directory early in init process is now accepted and ready to land.
Sat, Jun 15, 18:21
markblundeberg added a comment to D3312: create net-specific data directory early in init process.

Discussions with @Fabien make it clear that this is pretty ugly behaviour, and I've forwarded this problem to Core to see if they have some solutions in mind. https://github.com/bitcoin/bitcoin/issues/16220

Sat, Jun 15, 18:16
teamcity added a comment to D3312: create net-specific data directory early in init process.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Sat, Jun 15, 18:13
markblundeberg added a comment to D3312: create net-specific data directory early in init process.

add TODO comments to aid in clean backporting one day (when Core figures out
how they want to fix this)

Sat, Jun 15, 18:13
teamcity added a comment to D3340: Cleanup ibd.sh.

Build Bitcoin-ABC / Master / Nightly Builds / Bitcoin-ABC IBD Diff Testing passed.

Sat, Jun 15, 09:26
teamcity added a comment to D3318: [LINTER] Prevent including a source file.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Sat, Jun 15, 07:55
Fabien committed rABCfce74c92e6a6: [LINTER] Enforce using angle brackets in #include directives (authored by Fabien).
[LINTER] Enforce using angle brackets in #include directives
Sat, Jun 15, 07:54
Fabien closed D3319: [LINTER] Enforce using angle brackets in #include directives.
Sat, Jun 15, 07:54
teamcity added a comment to D3318: [LINTER] Prevent including a source file.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Sat, Jun 15, 07:45
Fabien added a comment to D3318: [LINTER] Prevent including a source file.

Add an exception for the crypto/ctaes/ctaes.c include in crypto.aes.cpp.

Sat, Jun 15, 07:44
Fabien added a comment to D3333: Avoid including a C file in crypto/aes.cpp.

This is a 5% performance increase, not a regression. Anyway, I discard it.

Sat, Jun 15, 07:24
teamcity added a comment to D3340: Cleanup ibd.sh.

Build Bitcoin-ABC / Master / Nightly Builds / Bitcoin-ABC IBD Diff Testing started.

Sat, Jun 15, 02:45
markblundeberg added inline comments to D1438: Add a NUM2BIN test with a 5 byte operand.
Sat, Jun 15, 02:41
teamcity added a comment to D3253: Remove Schnorr activation.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Sat, Jun 15, 01:59
markblundeberg added inline comments to D3253: Remove Schnorr activation.
Sat, Jun 15, 01:52
teamcity added a comment to D3253: Remove Schnorr activation.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Sat, Jun 15, 01:50
markblundeberg added a comment to D3253: Remove Schnorr activation.

keep functional test same name to allow diff to show properly

Sat, Jun 15, 01:50
teamcity added a comment to D3344: Merge #10999: Fix amounts formatting in `decoderawtransaction`.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Sat, Jun 15, 01:21
teamcity added a comment to D3344: Merge #10999: Fix amounts formatting in `decoderawtransaction`.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Sat, Jun 15, 01:10
nakihito added a comment to D3344: Merge #10999: Fix amounts formatting in `decoderawtransaction`.

Removed #include <amount.h> from core_io.h and changed ValueFromAmount() to pass amount by value rather than pass by reference.

Sat, Jun 15, 01:10
nakihito added a comment to D3344: Merge #10999: Fix amounts formatting in `decoderawtransaction`.

developer notes are missing.

Sat, Jun 15, 01:07
D3344: Merge #10999: Fix amounts formatting in `decoderawtransaction` now requires changes to proceed.

developer notes are missing.

Sat, Jun 15, 00:39
teamcity added a comment to D3347: [script_tests] improve coverage of minimal number encoding.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Sat, Jun 15, 00:35
markblundeberg added inline comments to D3332: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests.
Sat, Jun 15, 00:34
markblundeberg added inline comments to D3253: Remove Schnorr activation.
Sat, Jun 15, 00:32
D3193: Added update-chainparams.py to fetch and replace assume valid block values from a node using HTTP RPC now requires changes to proceed.
Sat, Jun 15, 00:32
markblundeberg added a comment to D3347: [script_tests] improve coverage of minimal number encoding.

(Also I find it a bit odd that we have a known error that triggers UNKNOWN_ERROR (this is because it works by throwing an exception instead of doing the usual s_error mechanism). Would be good to make it clearer, but that can be a separate diff.)

Sat, Jun 15, 00:31
teamcity added a comment to D3344: Merge #10999: Fix amounts formatting in `decoderawtransaction`.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Sat, Jun 15, 00:31
teamcity added a comment to D3347: [script_tests] improve coverage of minimal number encoding.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Sat, Jun 15, 00:28
markblundeberg created D3347: [script_tests] improve coverage of minimal number encoding.
Sat, Jun 15, 00:28
teamcity added a comment to D3344: Merge #10999: Fix amounts formatting in `decoderawtransaction`.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Sat, Jun 15, 00:23
nakihito added a comment to D3344: Merge #10999: Fix amounts formatting in `decoderawtransaction`.

Removed extra include in core_write.cpp and bracketed include in core_io.h.

Sat, Jun 15, 00:23
jasonbcox added inline comments to D3332: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests.
Sat, Jun 15, 00:20
jasonbcox added inline comments to D3253: Remove Schnorr activation.
Sat, Jun 15, 00:20
jasonbcox added inline comments to D3331: remove effect of SCRIPT_ENABLE_SCHNORR flag.
Sat, Jun 15, 00:18
D3253: Remove Schnorr activation now requires changes to proceed.
Sat, Jun 15, 00:09
deadalnix committed rABC33ff49689bcd: Make CMutableTransaction constructor explicit (authored by MarcoFalke <falke.marco@gmail.com>).
Make CMutableTransaction constructor explicit
Sat, Jun 15, 00:08
deadalnix closed D3339: Make CMutableTransaction constructor explicit.
Sat, Jun 15, 00:08
deadalnix committed rABC06ac73365f35: bitcoin-tx: Remove unused for loop (authored by MarcoFalke <falke.marco@gmail.com>).
bitcoin-tx: Remove unused for loop
Sat, Jun 15, 00:05
deadalnix closed D3338: bitcoin-tx: Remove unused for loop.
Sat, Jun 15, 00:04
deadalnix committed rABCadaf42727dcf: Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&) (authored by practicalswift <practicalswift@users.noreply.github.com>).
Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&)
Sat, Jun 15, 00:01
deadalnix closed D3337: Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&).
Sat, Jun 15, 00:00

Fri, Jun 14

D3344: Merge #10999: Fix amounts formatting in `decoderawtransaction` now requires changes to proceed.
Fri, Jun 14, 23:58
D3346: bench: Simplify CoinSelection is now accepted and ready to land.
Fri, Jun 14, 23:52
D3339: Make CMutableTransaction constructor explicit is now accepted and ready to land.
Fri, Jun 14, 23:49
deadalnix committed rABC0f49f7a5185d: Kill MAX_FREE_TRANSACTION_CREATE_SIZE (authored by deadalnix).
Kill MAX_FREE_TRANSACTION_CREATE_SIZE
Fri, Jun 14, 23:44
deadalnix closed D3345: Kill MAX_FREE_TRANSACTION_CREATE_SIZE.
Fri, Jun 14, 23:44
D3333: Avoid including a C file in crypto/aes.cpp now requires changes to proceed.

You prevent any inlining here. This is why you get 5% perf regression. Don't do this.

Fri, Jun 14, 23:38
teamcity added a comment to D3346: bench: Simplify CoinSelection.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fri, Jun 14, 23:13
teamcity added a comment to D3346: bench: Simplify CoinSelection.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fri, Jun 14, 23:06
deadalnix created D3346: bench: Simplify CoinSelection.
Fri, Jun 14, 23:06
teamcity added a comment to D3345: Kill MAX_FREE_TRANSACTION_CREATE_SIZE.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fri, Jun 14, 22:17
D3345: Kill MAX_FREE_TRANSACTION_CREATE_SIZE is now accepted and ready to land.
Fri, Jun 14, 22:16
teamcity added a comment to D3344: Merge #10999: Fix amounts formatting in `decoderawtransaction`.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fri, Jun 14, 22:15
D3338: bitcoin-tx: Remove unused for loop is now accepted and ready to land.
Fri, Jun 14, 22:14
D3337: Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&) is now accepted and ready to land.
Fri, Jun 14, 22:13
jasonbcox added inline comments to D3336: tests: Avoid copies of CTransaction.
Fri, Jun 14, 22:12
teamcity added a comment to D3345: Kill MAX_FREE_TRANSACTION_CREATE_SIZE.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fri, Jun 14, 22:10
deadalnix created D3345: Kill MAX_FREE_TRANSACTION_CREATE_SIZE.
Fri, Jun 14, 22:10
teamcity added a comment to D3295: Added a script to automate collecting and updating seeds.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fri, Jun 14, 22:06
teamcity added a comment to D3344: Merge #10999: Fix amounts formatting in `decoderawtransaction`.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fri, Jun 14, 22:06
nakihito created D3344: Merge #10999: Fix amounts formatting in `decoderawtransaction`.
Fri, Jun 14, 22:05
jasonbcox updated the test plan for D3295: Added a script to automate collecting and updating seeds.
Fri, Jun 14, 22:04
teamcity added a comment to D3295: Added a script to automate collecting and updating seeds.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fri, Jun 14, 22:00
jasonbcox added a comment to D3295: Added a script to automate collecting and updating seeds.
  • Added sanity checks at various steps in the seed updating process
  • Added basic error checking
  • Added ability to skip one set of seeds if it fails
Fri, Jun 14, 22:00
teamcity added a comment to D3343: [refactor] Make TransactionWithinChainLimit more flexible.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fri, Jun 14, 21:36
teamcity added a comment to D3343: [refactor] Make TransactionWithinChainLimit more flexible.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fri, Jun 14, 21:26
deadalnix created D3343: [refactor] Make TransactionWithinChainLimit more flexible.
Fri, Jun 14, 21:26
teamcity added a comment to D3342: Use mempool's descendent count in the wallet code.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fri, Jun 14, 21:18
teamcity added a comment to D3342: Use mempool's descendent count in the wallet code.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fri, Jun 14, 21:12
deadalnix retitled D3342: Use mempool's descendent count in the wallet code from Use mempool's descendent count int he wallet code to Use mempool's descendent count in the wallet code.
Fri, Jun 14, 21:10
deadalnix updated the summary of D3342: Use mempool's descendent count in the wallet code.
Fri, Jun 14, 21:09
teamcity added a comment to D3342: Use mempool's descendent count in the wallet code.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fri, Jun 14, 21:09
deadalnix added a comment to D3342: Use mempool's descendent count in the wallet code.

Calculate descendant maximum thoroughly

Fri, Jun 14, 21:08
nakihito added a comment to D3308: Merge #9894: remove 'label' filter for rpc command help.

This was the state of Core when this backport was landed: https://github.com/instagibbs/bitcoin/blob/666597798c07d9df06681be63d2b2f51f0d5ca8a/src/wallet/rpcwallet.cpp
The important point to note is the array on line 2997. The difference from our code right now comes from an out of order backport here: https://reviews.bitcoinabc.org/D1986. The original PR for D1986 was landed in Core on March 22, 2018. The PR for this patch was originally landed in Core on March 1, 2017.
Core does not have getlabeladdress, getreceivedbylabel, listreceivedbylabel, setlabel. Reading some of the discussion related to this PR (https://github.com/bitcoin/bitcoin/pull/9894, https://github.com/bitcoin/bitcoin/pull/11536, and https://github.com/bitcoin/bitcoin/pull/12892), it appears the RPCs went from label to account in Core:

Fri, Jun 14, 21:05
teamcity added a comment to D3342: Use mempool's descendent count in the wallet code.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fri, Jun 14, 21:03
deadalnix created D3342: Use mempool's descendent count in the wallet code.
Fri, Jun 14, 21:03
teamcity added a comment to D3318: [LINTER] Prevent including a source file.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fri, Jun 14, 20:46
teamcity added a comment to D3318: [LINTER] Prevent including a source file.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fri, Jun 14, 20:38
Fabien added a comment to D3318: [LINTER] Prevent including a source file.

Don't filter c files.

Fri, Jun 14, 20:37
Fabien added a comment to D3333: Avoid including a C file in crypto/aes.cpp.

I ran the benchmark from D3341 and get the following results:

  • There is no obvious performance difference using Clang 6.0.0
  • There is a low performance improvement with GCC 7.4.0 (~5%)
Fri, Jun 14, 20:35
teamcity added a comment to D3341: Add benchmark for AES.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fri, Jun 14, 20:09