Page MenuHomePhabricator
Feed All Stories

Yesterday

deadalnix added inline comments to D2561: Make --enable-debug to pick better options.
Mon, Feb 18, 22:22
teamcity added a comment to D2557: Add a linter to detect python % format and convert them to use .format().

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Mon, Feb 18, 21:20
teamcity added a comment to D2557: Add a linter to detect python % format and convert them to use .format().

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Mon, Feb 18, 21:07
Fabien updated the summary of D2557: Add a linter to detect python % format and convert them to use .format().
Mon, Feb 18, 21:06
Fabien updated the diff for D2557: Add a linter to detect python % format and convert them to use .format().

More special cases handling:

  • Allow nested formatting in functions, lists or dictionaries
  • Allow multiple formatting on a single line
  • Handle special cases for %i (no longer exist), %s (more strict behavior), %d, %r and %-
  • Replace %% with %
Mon, Feb 18, 21:06
jasonbcox committed rABCd252e8987d66: Added missing release notes for 0.19 (authored by jasonbcox).
Added missing release notes for 0.19
Mon, Feb 18, 19:47
jasonbcox closed D2563: Added missing release notes for 0.19.
Mon, Feb 18, 19:47
jasonbcox committed rABC15445e3a4ab2: Update manpages for 0.19 (authored by jasonbcox).
Update manpages for 0.19
Mon, Feb 18, 19:46
jasonbcox closed D2565: Update manpages for 0.19.
Mon, Feb 18, 19:45
jasonbcox committed rABCc148a1582e7b: Update chainparams for 0.19 (authored by jasonbcox).
Update chainparams for 0.19
Mon, Feb 18, 19:45
jasonbcox closed D2564: Update chainparams for 0.19.
Mon, Feb 18, 19:45
deadalnix accepted D2563: Added missing release notes for 0.19.
Mon, Feb 18, 19:28
deadalnix accepted D2564: Update chainparams for 0.19.
Mon, Feb 18, 19:28
deadalnix accepted D2565: Update manpages for 0.19.
Mon, Feb 18, 19:27
teamcity added a comment to D2565: Update manpages for 0.19.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Mon, Feb 18, 19:27
markblundeberg accepted D2563: Added missing release notes for 0.19.
Mon, Feb 18, 19:25
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC65fd352a34b9: un-mention segwit in addnode help text (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
un-mention segwit in addnode help text
Mon, Feb 18, 19:19
Diffusion closed D2562: un-mention segwit in addnode help text.
Mon, Feb 18, 19:19
jasonbcox added inline comments to D2565: Update manpages for 0.19.
Mon, Feb 18, 19:16
teamcity added a comment to D2565: Update manpages for 0.19.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Mon, Feb 18, 19:13
Herald added a reviewer for D2565: Update manpages for 0.19: Restricted Project.
Mon, Feb 18, 19:13
jasonbcox triaged T542: Give proper error message when DISPLAY is not set (rather than crash) as Low priority.
Mon, Feb 18, 19:08 ยท Bootcamp, Restricted Project
teamcity added a comment to D2564: Update chainparams for 0.19.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Mon, Feb 18, 18:55
teamcity added a comment to D2563: Added missing release notes for 0.19.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Mon, Feb 18, 18:47
teamcity added a comment to D2564: Update chainparams for 0.19.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Mon, Feb 18, 18:41
Herald added a reviewer for D2564: Update chainparams for 0.19: Restricted Project.
Mon, Feb 18, 18:40
teamcity added a comment to D2563: Added missing release notes for 0.19.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Mon, Feb 18, 18:33
Herald added a reviewer for D2563: Added missing release notes for 0.19: Restricted Project.
Mon, Feb 18, 18:32
jasonbcox accepted D2562: un-mention segwit in addnode help text.
Mon, Feb 18, 17:27
teamcity added a comment to D2562: un-mention segwit in addnode help text.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Mon, Feb 18, 16:01
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCdde1e30c72ff: CONTRIBUTING.md : recommend ccache (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
CONTRIBUTING.md : recommend ccache
Mon, Feb 18, 15:48
Diffusion closed D2554: CONTRIBUTING.md : recommend ccache.
Mon, Feb 18, 15:47
teamcity added a comment to D2562: un-mention segwit in addnode help text.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Mon, Feb 18, 15:47
Herald added a reviewer for D2562: un-mention segwit in addnode help text: deadalnix.
Mon, Feb 18, 15:45
Fabien planned changes to D2557: Add a linter to detect python % format and convert them to use .format().

The second limitation is an important part of the use case. It needs to be handled correctly.

Mon, Feb 18, 11:53
teamcity added a comment to D2558: Integrates the python format linter with arcanist.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Mon, Feb 18, 11:17
teamcity added a comment to D2557: Add a linter to detect python % format and convert them to use .format().

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Mon, Feb 18, 11:09
teamcity added a comment to D2558: Integrates the python format linter with arcanist.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Mon, Feb 18, 11:03
Fabien updated the diff for D2558: Integrates the python format linter with arcanist.

Rtrim the original content in arcanist message.
Under some circumstance arcanist would also replace the line break,
resulting in 2 lines being merged.

Mon, Feb 18, 11:02
teamcity added a comment to D2557: Add a linter to detect python % format and convert them to use .format().

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Mon, Feb 18, 10:55
Fabien updated the diff for D2557: Add a linter to detect python % format and convert them to use .format().

Found another limitation, add a commented test case in the txt file to reflect it

Mon, Feb 18, 10:54
Fabien updated the summary of D2557: Add a linter to detect python % format and convert them to use .format().
Mon, Feb 18, 10:45
Fabien updated the summary of D2557: Add a linter to detect python % format and convert them to use .format().
Mon, Feb 18, 10:45
teamcity added a comment to D2557: Add a linter to detect python % format and convert them to use .format().

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Mon, Feb 18, 10:09
teamcity added a comment to D2557: Add a linter to detect python % format and convert them to use .format().

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Mon, Feb 18, 09:55
Fabien updated the diff for D2557: Add a linter to detect python % format and convert them to use .format().

Add a missing case when line ends with % and is not followed by \

Mon, Feb 18, 09:54

Sun, Feb 17

Mengerian added a comment to D2341: Enforce NULLDUMMY.

Hey @dagurval It seems this is now too late to include for "Great Wall" activation.

Sun, Feb 17, 22:04
markblundeberg added inline comments to D2457: [schnorr] Refactor the signature process in reusable component.
Sun, Feb 17, 01:16

Sat, Feb 16

teamcity added a comment to D2561: Make --enable-debug to pick better options.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Sat, Feb 16, 15:51
teamcity added a comment to D2561: Make --enable-debug to pick better options.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Sat, Feb 16, 15:37
Herald added a reviewer for D2561: Make --enable-debug to pick better options: deadalnix.
Sat, Feb 16, 15:36
teamcity added a comment to D2560: Add a test for signrawtransaction with various sighashes parameters.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Sat, Feb 16, 14:24
teamcity added a comment to D2560: Add a test for signrawtransaction with various sighashes parameters.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Sat, Feb 16, 14:10
Herald added a reviewer for D2560: Add a test for signrawtransaction with various sighashes parameters: deadalnix.
Sat, Feb 16, 14:09
deadalnix accepted D2558: Integrates the python format linter with arcanist.
Sat, Feb 16, 13:35
teamcity added a comment to D2558: Integrates the python format linter with arcanist.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Sat, Feb 16, 08:24
teamcity added a comment to D2558: Integrates the python format linter with arcanist.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Sat, Feb 16, 08:10
Fabien updated the diff for D2558: Integrates the python format linter with arcanist.

Remove php closing tag and fix linter exclusion filter in .arclint

Sat, Feb 16, 08:09
Fabien planned changes to D2558: Integrates the python format linter with arcanist.
Sat, Feb 16, 08:08
teamcity added a comment to D2559: fix Qt crash.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Sat, Feb 16, 03:55
teamcity added a comment to D2559: fix Qt crash.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Sat, Feb 16, 03:51
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCeafa2b46d818: fix Qt crash (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
fix Qt crash
Sat, Feb 16, 03:41
teamcity added a comment to D2559: fix Qt crash.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Sat, Feb 16, 03:41
Diffusion closed D2559: fix Qt crash.
Sat, Feb 16, 03:41
markblundeberg updated the diff for D2559: fix Qt crash.

s/Qt/bitcoin-qt

Sat, Feb 16, 03:40
teamcity added a comment to D2559: fix Qt crash.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Sat, Feb 16, 03:36
markblundeberg updated the diff for D2559: fix Qt crash.

add release note

Sat, Feb 16, 03:35
jasonbcox accepted D2559: fix Qt crash.
Sat, Feb 16, 03:22
teamcity added a comment to D2559: fix Qt crash.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Sat, Feb 16, 03:18
teamcity added a comment to D2559: fix Qt crash.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Sat, Feb 16, 03:04
Herald added a reviewer for D2559: fix Qt crash: deadalnix.
Sat, Feb 16, 03:02
markblundeberg added a comment to D2322: remove minimum total fee option.

Need fix: https://github.com/bitcoin/bitcoin/pull/11332

Sat, Feb 16, 02:41
markblundeberg added inline comments to D2322: remove minimum total fee option.
Sat, Feb 16, 02:22
deadalnix requested changes to D2558: Integrates the python format linter with arcanist.
Sat, Feb 16, 00:55
deadalnix added inline comments to D2558: Integrates the python format linter with arcanist.
Sat, Feb 16, 00:55
deadalnix accepted D2557: Add a linter to detect python % format and convert them to use .format().

I trust that you know what you are doing. It comes with tests and all, and worst case scenario, we can fix it.

Sat, Feb 16, 00:51

Fri, Feb 15

teamcity added a comment to D2558: Integrates the python format linter with arcanist.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fri, Feb 15, 21:22
teamcity added a comment to D2557: Add a linter to detect python % format and convert them to use .format().

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fri, Feb 15, 21:21
teamcity added a comment to D2558: Integrates the python format linter with arcanist.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fri, Feb 15, 21:08
teamcity added a comment to D2557: Add a linter to detect python % format and convert them to use .format().

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fri, Feb 15, 21:07
Fabien updated the diff for D2558: Integrates the python format linter with arcanist.

Rebase

Fri, Feb 15, 21:06
Fabien updated the diff for D2557: Add a linter to detect python % format and convert them to use .format().

Rebase

Fri, Feb 15, 21:06
teamcity added a comment to D2557: Add a linter to detect python % format and convert them to use .format().

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fri, Feb 15, 20:59
teamcity added a comment to D2558: Integrates the python format linter with arcanist.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fri, Feb 15, 20:51
teamcity added a comment to D2557: Add a linter to detect python % format and convert them to use .format().

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fri, Feb 15, 20:46
Harbormaster failed remote builds in B4999: Diff 7361 for D2557: Add a linter to detect python % format and convert them to use .format()!
Fri, Feb 15, 20:40
teamcity added a comment to D2557: Add a linter to detect python % format and convert them to use .format().

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Fri, Feb 15, 20:40
teamcity added a comment to D2558: Integrates the python format linter with arcanist.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fri, Feb 15, 20:38
Herald added a reviewer for D2558: Integrates the python format linter with arcanist: deadalnix.
Fri, Feb 15, 20:37
Fabien added a child revision for D2557: Add a linter to detect python % format and convert them to use .format(): D2558: Integrates the python format linter with arcanist.
Fri, Feb 15, 20:36
teamcity added a comment to D2557: Add a linter to detect python % format and convert them to use .format().

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fri, Feb 15, 20:26
Herald added a reviewer for D2557: Add a linter to detect python % format and convert them to use .format(): deadalnix.
Fri, Feb 15, 20:25
markblundeberg removed a task from D2349: fix confusingly named function parameter 'scriptSig': T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG.
Fri, Feb 15, 17:08
markblundeberg removed a revision from T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG: D2349: fix confusingly named function parameter 'scriptSig'.
Fri, Feb 15, 17:08
sickpig committed rABC74fdb9ee4424: Reset default -g -O2 flags when enable debug (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Reset default -g -O2 flags when enable debug
Fri, Feb 15, 16:29
sickpig closed D2556: Reset default -g -O2 flags when enable debug.
Fri, Feb 15, 16:29
deadalnix committed rABC392fbd574861: Update timing.json (authored by deadalnix).
Update timing.json
Fri, Feb 15, 16:08
deadalnix closed D2555: Update timing.json.
Fri, Feb 15, 16:08
Fabien requested changes to D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.
Fri, Feb 15, 16:06
deadalnix requested changes to D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.
Fri, Feb 15, 15:56