Page MenuHomePhabricator
Feed All Stories

Today

Fabien closed D11829: [avalanche] Remove the network bypass flag, make it default for avalanche outbounds.
Mon, Aug 8, 16:13
Fabien committed rABCd1eb6034187d: [avalanche] Remove the network bypass flag, make it default for avalanche… (authored by Fabien).
[avalanche] Remove the network bypass flag, make it default for avalanche…
Mon, Aug 8, 16:13
teamcity triaged T2595: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
Mon, Aug 8, 16:11
Fabien closed D11833: Fix a race in the net tests.
Mon, Aug 8, 15:55
Fabien committed rABC12677a9f321d: Fix a race in the net tests (authored by Fabien).
Fix a race in the net tests
Mon, Aug 8, 15:55
sdulfari accepted D11829: [avalanche] Remove the network bypass flag, make it default for avalanche outbounds.
Mon, Aug 8, 15:55
Fabien closed D11834: [avalanche] Fix abc_p2p_getavaaddr flakiness.
Mon, Aug 8, 15:55
Fabien committed rABCd1356c9f2cf2: [avalanche] Fix abc_p2p_getavaaddr flakiness (authored by Fabien).
[avalanche] Fix abc_p2p_getavaaddr flakiness
Mon, Aug 8, 15:55
kieran709 requested review of D11835: [Cashtab] Validation function for new wallet name length.
Mon, Aug 8, 15:54
Fabien updated the diff for D11829: [avalanche] Remove the network bypass flag, make it default for avalanche outbounds.

Expand the test case to cover the change

Mon, Aug 8, 15:50
sdulfari accepted D11833: Fix a race in the net tests.
Mon, Aug 8, 15:49
sdulfari accepted D11834: [avalanche] Fix abc_p2p_getavaaddr flakiness.
Mon, Aug 8, 15:45
sdulfari added inline comments to D11829: [avalanche] Remove the network bypass flag, make it default for avalanche outbounds.
Mon, Aug 8, 15:34
Fabien published D11834: [avalanche] Fix abc_p2p_getavaaddr flakiness for review.
Mon, Aug 8, 14:23
teamcity awarded D11834: [avalanche] Fix abc_p2p_getavaaddr flakiness a Haypence token.
Mon, Aug 8, 14:06
Fabien updated the summary of D11829: [avalanche] Remove the network bypass flag, make it default for avalanche outbounds.
Mon, Aug 8, 09:41
Fabien updated the diff for D11829: [avalanche] Remove the network bypass flag, make it default for avalanche outbounds.

Rebase on top of D11833.

Mon, Aug 8, 09:39
teamcity awarded D11833: Fix a race in the net tests a Haypence token.
Mon, Aug 8, 09:35
Fabien added a comment to D11833: Fix a race in the net tests.

@bot build-tsan

Mon, Aug 8, 09:35
Fabien requested review of D11833: Fix a race in the net tests.
Mon, Aug 8, 09:35

Sat, Aug 6

teamcity triaged T2594: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.
Sat, Aug 6, 12:25
Fabien requested review of D11829: [avalanche] Remove the network bypass flag, make it default for avalanche outbounds.
Sat, Aug 6, 12:02
Fabien closed D11828: Add unit test for the outbound connection logic.
Sat, Aug 6, 12:00
Fabien committed rABC9b5e2671d190: Add unit test for the outbound connection logic (authored by Fabien).
Add unit test for the outbound connection logic
Sat, Aug 6, 12:00
Fabien closed D11827: Add a method to make addrman deterministic.
Sat, Aug 6, 11:59
Fabien committed rABCbb9328ffcfe2: Add a method to make addrman deterministic (authored by Fabien).
Add a method to make addrman deterministic
Sat, Aug 6, 11:59
welshjones56 updated welshjones56.
Sat, Aug 6, 09:35
welshjones56 updated welshjones56.
Sat, Aug 6, 09:16
sdulfari requested changes to D11829: [avalanche] Remove the network bypass flag, make it default for avalanche outbounds.
Sat, Aug 6, 08:25
sdulfari accepted D11827: Add a method to make addrman deterministic.
Sat, Aug 6, 08:11
sdulfari accepted D11828: Add unit test for the outbound connection logic.
Sat, Aug 6, 08:10

Fri, Aug 5

kieran709 added a comment to D11741: [Cashtab] currency.prefixes & currency.tokenPrefixes converted to strings.

I noticed that in ScanQrCode there is a reference on line 72 to currency.tokenPrefix, which does not exist in the currency object, so it will not be a problem to remove them altogether, but we may need another task / diff to fix what is happening in ScanQrCode.

Fri, Aug 5, 18:38
kieran709 updated the diff for D11831: [Cashtab] Remove color change of address on hover in contact list.

Responding to review feedback, removed hover effect from balances in saved wallet dropdown & names in the contact list.

Fri, Aug 5, 18:20
kieran709 closed D11826: [Cashtab] Remove classNames from Tx.js.
Fri, Aug 5, 17:42
kieran709 committed rABC2163ea29329d: [Cashtab] Remove classNames from Tx.js (authored by kieran709).
[Cashtab] Remove classNames from Tx.js
Fri, Aug 5, 17:42
bytesofman accepted D11826: [Cashtab] Remove classNames from Tx.js.
Fri, Aug 5, 17:29
bytesofman requested changes to D11627: [Cashtab] Hide msgs from unknown senders option.
Fri, Aug 5, 17:18
bytesofman requested changes to D11831: [Cashtab] Remove color change of address on hover in contact list.

Please also remove this effect from

Fri, Aug 5, 17:12
teamcity added a comment to D11832: [Cashtab] [utxo handling p2] Sort etoken and non-etoken utxos.
Fri, Aug 5, 17:09
bytesofman planned changes to D11832: [Cashtab] [utxo handling p2] Sort etoken and non-etoken utxos.

There are some optimizations available here compared to the way it was done as a proof of concept in D11385

Fri, Aug 5, 17:07
bytesofman requested review of D11832: [Cashtab] [utxo handling p2] Sort etoken and non-etoken utxos.
Fri, Aug 5, 17:07
kieran709 requested review of D11831: [Cashtab] Remove color change of address on hover in contact list.
Fri, Aug 5, 15:42
kieran709 updated the diff for D11627: [Cashtab] Hide msgs from unknown senders option.

Responding to review feedback

Fri, Aug 5, 15:09
deadalnix requested changes to D11750: [avalanche] Make proof dust threshold configurable.

I don't think this design with a config is a plus. A ton of code just got significantly more convoluted.

Fri, Aug 5, 12:32
Fabien accepted D11830: [avalanche] Increase proof dust threshold.
Fri, Aug 5, 09:18
Fabien updated the diff for D11829: [avalanche] Remove the network bypass flag, make it default for avalanche outbounds.

Update formatting as per D11828

Fri, Aug 5, 08:51
Fabien updated the diff for D11828: Add unit test for the outbound connection logic.

Improve formatting

Fri, Aug 5, 08:44
Fabien added inline comments to D11828: Add unit test for the outbound connection logic.
Fri, Aug 5, 08:43
Fabien updated the diff for D11827: Add a method to make addrman deterministic.

Improve as per feedback

Fri, Aug 5, 08:24
sdulfari added inline comments to D11828: Add unit test for the outbound connection logic.
Fri, Aug 5, 06:32

Thu, Aug 4

teamcity added a comment to D11830: [avalanche] Increase proof dust threshold.
Thu, Aug 4, 23:01
sdulfari requested changes to D11827: Add a method to make addrman deterministic.
Thu, Aug 4, 22:58
sdulfari requested review of D11830: [avalanche] Increase proof dust threshold.
Thu, Aug 4, 22:50
Fabien requested review of D11829: [avalanche] Remove the network bypass flag, make it default for avalanche outbounds.
Thu, Aug 4, 20:39
Fabien requested review of D11828: Add unit test for the outbound connection logic.
Thu, Aug 4, 20:26
Fabien requested review of D11827: Add a method to make addrman deterministic.
Thu, Aug 4, 20:20
sdulfari updated the diff for D11750: [avalanche] Make proof dust threshold configurable.

Rebase on new unit test

Thu, Aug 4, 19:51
kieran709 updated the summary of D11826: [Cashtab] Remove classNames from Tx.js.
Thu, Aug 4, 14:38
kieran709 requested review of D11826: [Cashtab] Remove classNames from Tx.js.
Thu, Aug 4, 14:36
Mengerian closed D11825: [website] Fix some typos in Avalanche Dev Update.
Thu, Aug 4, 13:58
Mengerian committed rABCWEBee677262354b: [website] Fix some typos in Avalanche Dev Update (authored by Mengerian).
[website] Fix some typos in Avalanche Dev Update
Thu, Aug 4, 13:58
Mher1100 awarded T476: Write a script to automate the collection of gitian outputs a Love token.
Thu, Aug 4, 07:28 · Restricted Project
bytesofman accepted D11825: [website] Fix some typos in Avalanche Dev Update.
Thu, Aug 4, 05:43
Mengerian requested review of D11825: [website] Fix some typos in Avalanche Dev Update.
Thu, Aug 4, 05:30
teamcity closed T2591: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux ARM is broken. as Resolved.
Thu, Aug 4, 03:46
abc-bot committed rABCd1552c9058d6: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Thu, Aug 4, 03:21
Mengerian closed D11824: [website] Add Avalanche Development Update blog post for Aug 2022.
Thu, Aug 4, 02:48
Mengerian committed rABCWEB299029d68a87: [website] Add Avalanche Development Update blog post for Aug 2022 (authored by Mengerian).
[website] Add Avalanche Development Update blog post for Aug 2022
Thu, Aug 4, 02:48
abc-bot committed rABC27422074e579: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Thu, Aug 4, 02:06
teamcity closed T2587: Build Bitcoin-ABC / Nightly Builds / Gitian Builds / Gitian - OSX is broken. as Resolved.
Thu, Aug 4, 01:54

Wed, Aug 3

bytesofman accepted D11824: [website] Add Avalanche Development Update blog post for Aug 2022.
Wed, Aug 3, 23:52
Mengerian updated the diff for D11824: [website] Add Avalanche Development Update blog post for Aug 2022.

Add "upcoming" to clarify that post-consensus launch will be in the future

Wed, Aug 3, 23:48
Mengerian updated the diff for D11824: [website] Add Avalanche Development Update blog post for Aug 2022.

Add more links to Diffs

Wed, Aug 3, 23:06
Mengerian updated the diff for D11824: [website] Add Avalanche Development Update blog post for Aug 2022.

Line wrapping

Wed, Aug 3, 18:14
Mengerian requested review of D11824: [website] Add Avalanche Development Update blog post for Aug 2022.
Wed, Aug 3, 17:54
bytesofman requested changes to D11823: [Cashtab] Add ability to rename active wallet.
Wed, Aug 3, 16:45
emack accepted D11818: [Cashtab] [utxo handling p1] Add chronik utxo fetch functionality.
Wed, Aug 3, 15:30
sdulfari closed D11821: [avalanche] Bump stake used in proof deserialization tests.
Wed, Aug 3, 15:28
sdulfari committed rABCc59a1cd712e4: [avalanche] Bump stake used in proof deserialization tests (authored by sdulfari).
[avalanche] Bump stake used in proof deserialization tests
Wed, Aug 3, 15:27
sdulfari closed D11822: [avalanche] Add coins directly instead of using coinbases in processor unit tests.
Wed, Aug 3, 15:26
sdulfari committed rABC90b5164c2248: [avalanche] Add coins directly instead of using coinbases in processor unit… (authored by sdulfari).
[avalanche] Add coins directly instead of using coinbases in processor unit…
Wed, Aug 3, 15:26
sdulfari closed D11820: [avalanche] Use MIN_VALID_PROOF_SCORE where appropriate.
Wed, Aug 3, 15:22
sdulfari committed rABC61577540686e: [avalanche] Use MIN_VALID_PROOF_SCORE where appropriate (authored by sdulfari).
[avalanche] Use MIN_VALID_PROOF_SCORE where appropriate
Wed, Aug 3, 15:22
kieran709 updated the summary of D11823: [Cashtab] Add ability to rename active wallet.
Wed, Aug 3, 14:55
kieran709 planned changes to D11823: [Cashtab] Add ability to rename active wallet.
Wed, Aug 3, 14:55
kieran709 requested review of D11823: [Cashtab] Add ability to rename active wallet.
Wed, Aug 3, 14:44
bytesofman added inline comments to D11818: [Cashtab] [utxo handling p1] Add chronik utxo fetch functionality.
Wed, Aug 3, 14:18
bytesofman updated the diff for D11818: [Cashtab] [utxo handling p1] Add chronik utxo fetch functionality.

Adding unit test and mocks

Wed, Aug 3, 14:13
emack added inline comments to D11818: [Cashtab] [utxo handling p1] Add chronik utxo fetch functionality.
Wed, Aug 3, 13:52
Fabien accepted D11822: [avalanche] Add coins directly instead of using coinbases in processor unit tests.
Wed, Aug 3, 13:16
Fabien accepted D11821: [avalanche] Bump stake used in proof deserialization tests.
Wed, Aug 3, 12:38
teamcity closed T2589: Build Bitcoin-ABC / Master / Coverage is broken. as Resolved.
Wed, Aug 3, 12:05
teamcity closed T2590: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Resolved.
Wed, Aug 3, 11:53
teamcity triaged T2591: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux ARM is broken. as Unbreak Now! priority.
Wed, Aug 3, 11:38
abc-bot committed rABCe2157bd35322: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Wed, Aug 3, 11:38
teamcity triaged T2590: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
Wed, Aug 3, 11:16
teamcity added a comment to D11821: [avalanche] Bump stake used in proof deserialization tests.
Wed, Aug 3, 11:03
teamcity triaged T2589: Build Bitcoin-ABC / Master / Coverage is broken. as Unbreak Now! priority.
Wed, Aug 3, 11:03
abc-bot committed rABCe634f8028e57: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Wed, Aug 3, 11:02
teamcity added a comment to D11821: [avalanche] Bump stake used in proof deserialization tests.
Wed, Aug 3, 11:02