Page MenuHomePhabricator
Feed All Stories

Today

deadalnix requested changes to D2667: [CMAKE] Fix bitcoin-qt cross compilation for Windows.
Wed, Apr 24, 21:42
teamcity added a comment to D2876: [qt] Simplifies boolean expression model && model->haveWatchOnly().

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Wed, Apr 24, 21:03
teamcity added a comment to D2875: [qt] Avoid potential null pointer dereference in TransactionView::exportClicked().

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Wed, Apr 24, 21:00
teamcity added a comment to D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Wed, Apr 24, 20:49
teamcity added a comment to D2876: [qt] Simplifies boolean expression model && model->haveWatchOnly().

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Wed, Apr 24, 20:49
jasonbcox updated the summary of D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.
Wed, Apr 24, 20:49
Herald added a reviewer for D2876: [qt] Simplifies boolean expression model && model->haveWatchOnly(): Restricted Project.
Wed, Apr 24, 20:48
teamcity added a comment to D2875: [qt] Avoid potential null pointer dereference in TransactionView::exportClicked().

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Wed, Apr 24, 20:47
Herald added a reviewer for D2875: [qt] Avoid potential null pointer dereference in TransactionView::exportClicked(): Restricted Project.
Wed, Apr 24, 20:46
teamcity added a comment to D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Wed, Apr 24, 20:36
jasonbcox planned changes to D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.

Doing another round of self review and annotating deviations from the original PR.

Wed, Apr 24, 20:36
Herald added a reviewer for D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp: Restricted Project.
Wed, Apr 24, 20:35
Fabien requested review of D2667: [CMAKE] Fix bitcoin-qt cross compilation for Windows.
Wed, Apr 24, 20:22
deadalnix requested changes to D2667: [CMAKE] Fix bitcoin-qt cross compilation for Windows.
Wed, Apr 24, 19:43
Fabien added a comment to D2682: [CMAKE] Avoid displaying the console when launching bitcoin-qt.exe.

From the cmake mailing list, this tends to confirm that this property has no impact outside of a windows build: https://cmake.org/pipermail/cmake/2008-March/020577.html

Wed, Apr 24, 16:07
Fabien requested changes to D2846: Do not allow users to get keys from keypool without reserving them.

If -deprecatedrpc=fundrawtransaction is set and the reserveChangeKey option is true, you end up removing the key twice.

Wed, Apr 24, 16:04
jasonbcox accepted D2682: [CMAKE] Avoid displaying the console when launching bitcoin-qt.exe.
Wed, Apr 24, 16:03
teamcity added a comment to D2873: serialize: Serialization support for big-endian 32-bit ints..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Wed, Apr 24, 15:35
markblundeberg added a revision to T589: BIP157 & BIP158 backports: D2873: serialize: Serialization support for big-endian 32-bit ints..
Wed, Apr 24, 15:22
markblundeberg added a task to D2873: serialize: Serialization support for big-endian 32-bit ints.: T589: BIP157 & BIP158 backports.
Wed, Apr 24, 15:22
teamcity added a comment to D2873: serialize: Serialization support for big-endian 32-bit ints..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Wed, Apr 24, 15:21
Herald added a reviewer for D2873: serialize: Serialization support for big-endian 32-bit ints.: deadalnix.
Wed, Apr 24, 15:20
Fabien added a comment to D2682: [CMAKE] Avoid displaying the console when launching bitcoin-qt.exe.

Link to the doc: https://cmake.org/cmake/help/v3.10/prop_tgt/WIN32_EXECUTABLE.html#prop_tgt:WIN32_EXECUTABLE

Wed, Apr 24, 14:24
teamcity added a comment to D2682: [CMAKE] Avoid displaying the console when launching bitcoin-qt.exe.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Wed, Apr 24, 14:00
teamcity added a comment to D2682: [CMAKE] Avoid displaying the console when launching bitcoin-qt.exe.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Wed, Apr 24, 13:47
Fabien requested review of D2682: [CMAKE] Avoid displaying the console when launching bitcoin-qt.exe.
Wed, Apr 24, 13:46
Fabien updated the diff for D2682: [CMAKE] Avoid displaying the console when launching bitcoin-qt.exe.

I discovered by chance that cmake targets have a property which does exactly the same
(setting the exact same flag) in a more cmake fashion way.
This property has no impact if the build is not a windows executable, so no need to
make it explicitely windows only.

Wed, Apr 24, 13:46
Fabien added inline comments to D2667: [CMAKE] Fix bitcoin-qt cross compilation for Windows.
Wed, Apr 24, 13:00
teamcity added a comment to D2667: [CMAKE] Fix bitcoin-qt cross compilation for Windows.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Wed, Apr 24, 12:53
Fabien added inline comments to D2667: [CMAKE] Fix bitcoin-qt cross compilation for Windows.
Wed, Apr 24, 12:43
teamcity added a comment to D2667: [CMAKE] Fix bitcoin-qt cross compilation for Windows.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Wed, Apr 24, 12:40
Fabien updated the diff for D2667: [CMAKE] Fix bitcoin-qt cross compilation for Windows.

Fix bugs in the contrib/convert-prl-libs-to-cmake.pl. This allows for
converting the windows plugin prl script rather than manually linking
the dependencies.

Wed, Apr 24, 12:39
teamcity added a comment to D2872: blockfilter: Refactor and add tests for BlockFilter construction.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Wed, Apr 24, 05:32
teamcity added a comment to D2872: blockfilter: Refactor and add tests for BlockFilter construction.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Wed, Apr 24, 05:19
markblundeberg added a revision to T589: BIP157 & BIP158 backports: D2872: blockfilter: Refactor and add tests for BlockFilter construction.
Wed, Apr 24, 05:19
markblundeberg added a task to D2872: blockfilter: Refactor and add tests for BlockFilter construction: T589: BIP157 & BIP158 backports.
Wed, Apr 24, 05:19
Herald added a reviewer for D2872: blockfilter: Refactor and add tests for BlockFilter construction: deadalnix.
Wed, Apr 24, 05:18
schancel added inline comments to D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
Wed, Apr 24, 04:41
schancel requested review of D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
Wed, Apr 24, 04:40
markblundeberg updated the task description for T589: BIP157 & BIP158 backports.
Wed, Apr 24, 01:16
markblundeberg added a comment to T589: BIP157 & BIP158 backports.

getting commit fef5adcc3 looks like it should be done after T590, though it can also wait.

Wed, Apr 24, 01:05
markblundeberg added a parent task for T590: Backport Core 14555: Move util files to new directory: T589: BIP157 & BIP158 backports.
Wed, Apr 24, 01:05 ยท Backport, Restricted Project
markblundeberg added a subtask for T589: BIP157 & BIP158 backports: T590: Backport Core 14555: Move util files to new directory.
Wed, Apr 24, 01:05
teamcity added a comment to D2871: Remove direct bitcoin calls from qt/optionsdialog.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Wed, Apr 24, 00:17
teamcity added a comment to D2871: Remove direct bitcoin calls from qt/optionsdialog.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Wed, Apr 24, 00:02
Herald added a reviewer for D2871: Remove direct bitcoin calls from qt/optionsdialog.cpp: Restricted Project.
Wed, Apr 24, 00:01

Yesterday

teamcity added a comment to D2846: Do not allow users to get keys from keypool without reserving them.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Tue, Apr 23, 23:19
teamcity added a comment to D2846: Do not allow users to get keys from keypool without reserving them.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Tue, Apr 23, 23:10
teamcity added a comment to D2846: Do not allow users to get keys from keypool without reserving them.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Tue, Apr 23, 23:05
nakihito updated the diff for D2846: Do not allow users to get keys from keypool without reserving them.

typo

Tue, Apr 23, 23:04
teamcity added a comment to D2846: Do not allow users to get keys from keypool without reserving them.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Tue, Apr 23, 22:56
nakihito updated the diff for D2846: Do not allow users to get keys from keypool without reserving them.

Changed location of deprecation check, removed excess deprecation checks, added new test case.

Tue, Apr 23, 22:55
jasonbcox committed rABC966fcf6ef3b0: Remove direct bitcoin calls from qt/rpcconsole.cpp (authored by Russell Yanofsky <russ@yanofsky.org>).
Remove direct bitcoin calls from qt/rpcconsole.cpp
Tue, Apr 23, 22:30
jasonbcox closed D2845: Remove direct bitcoin calls from qt/rpcconsole.cpp.
Tue, Apr 23, 22:30
jasonbcox committed rABCcdbb52ef348b: Remove direct bitcoin calls from qt/bantablemodel.cpp (authored by Russell Yanofsky <russ@yanofsky.org>).
Remove direct bitcoin calls from qt/bantablemodel.cpp
Tue, Apr 23, 22:23
jasonbcox closed D2822: Remove direct bitcoin calls from qt/bantablemodel.cpp.
Tue, Apr 23, 22:23
jasonbcox committed rABC11a062c29019: Remove direct bitcoin calls from qt/peertablemodel.cpp (authored by Russell Yanofsky <russ@yanofsky.org>).
Remove direct bitcoin calls from qt/peertablemodel.cpp
Tue, Apr 23, 22:06
jasonbcox closed D2821: Remove direct bitcoin calls from qt/peertablemodel.cpp.
Tue, Apr 23, 22:06
jasonbcox committed rABC23f2b13cbdb8: Remove direct bitcoin calls from qt/intro.cpp (authored by Russell Yanofsky <russ@yanofsky.org>).
Remove direct bitcoin calls from qt/intro.cpp
Tue, Apr 23, 22:02
jasonbcox closed D2819: Remove direct bitcoin calls from qt/intro.cpp.
Tue, Apr 23, 22:01
jasonbcox committed rABCd5744ecaae97: Remove direct bitcoin calls from qt/clientmodel.cpp (authored by Russell Yanofsky <russ@yanofsky.org>).
Remove direct bitcoin calls from qt/clientmodel.cpp
Tue, Apr 23, 21:35
jasonbcox closed D2818: Remove direct bitcoin calls from qt/clientmodel.cpp.
Tue, Apr 23, 21:35
jasonbcox committed rABC916ce3b5660d: Remove direct bitcoin calls from qt/splashscreen.cpp (authored by Russell Yanofsky <russ@yanofsky.org>).
Remove direct bitcoin calls from qt/splashscreen.cpp
Tue, Apr 23, 21:20
jasonbcox closed D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.
Tue, Apr 23, 21:19
deadalnix accepted D2821: Remove direct bitcoin calls from qt/peertablemodel.cpp.
Tue, Apr 23, 20:53
deadalnix accepted D2818: Remove direct bitcoin calls from qt/clientmodel.cpp.
Tue, Apr 23, 20:53
deadalnix accepted D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.
Tue, Apr 23, 20:50
nakihito added a comment to D2846: Do not allow users to get keys from keypool without reserving them.

Also making more changes as recommended by Fabien.

Tue, Apr 23, 20:15
jasonbcox requested changes to D2846: Do not allow users to get keys from keypool without reserving them.
Tue, Apr 23, 20:04
teamcity added a comment to D2795: Add additional unit tests for segwit recovery.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Tue, Apr 23, 19:39
teamcity added a comment to D2795: Add additional unit tests for segwit recovery.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Tue, Apr 23, 19:26
florian updated the diff for D2795: Add additional unit tests for segwit recovery.

Update tests to match the merged spec (test vectors: V6, V7, I10, I4, I5, I2, I1).

Tue, Apr 23, 19:24
teamcity added a comment to D2846: Do not allow users to get keys from keypool without reserving them.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Tue, Apr 23, 19:05
teamcity added a comment to D2846: Do not allow users to get keys from keypool without reserving them.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Tue, Apr 23, 18:52
nakihito updated the diff for D2846: Do not allow users to get keys from keypool without reserving them.

Deprecated -reserveChangeKey option rather than removing it. Changed deprecation comment to reflect next major update. Rebased.

Tue, Apr 23, 18:51
jasonbcox abandoned D1514: Update EMCH testvectors to match UTXO serialization.
Tue, Apr 23, 17:09
jasonbcox commandeered D1514: Update EMCH testvectors to match UTXO serialization.
Tue, Apr 23, 17:09
jasonbcox abandoned D1513: Add test/data directory to enable make check.
Tue, Apr 23, 17:09
jasonbcox commandeered D1513: Add test/data directory to enable make check.
Tue, Apr 23, 17:09
jasonbcox abandoned D1474: Include unverified UTXO commitment in Coinbase on generate.
Tue, Apr 23, 17:07
jasonbcox commandeered D1474: Include unverified UTXO commitment in Coinbase on generate.
Tue, Apr 23, 17:06
jasonbcox abandoned D1470: Add gitian-sigs path and description to use it.
Tue, Apr 23, 17:06
jasonbcox commandeered D1470: Add gitian-sigs path and description to use it.
Tue, Apr 23, 17:06
jasonbcox abandoned D1495: Add unit tests for combining UTXO commitments..
Tue, Apr 23, 17:05
jasonbcox commandeered D1495: Add unit tests for combining UTXO commitments..
Tue, Apr 23, 17:05
jasonbcox added a comment to D1074: Add Utxo Commitment wrapper around libsecp256k1.

If this diff is revisited, also land D1495

Tue, Apr 23, 17:05
jasonbcox abandoned D1150: [WIP] Extensible Blockchain Protocol first approach.
Tue, Apr 23, 17:02
jasonbcox abandoned D1074: Add Utxo Commitment wrapper around libsecp256k1.
Tue, Apr 23, 17:02
jasonbcox abandoned D1117: Integrate UtxoCommitment in CCoinView.
Tue, Apr 23, 17:02
jasonbcox commandeered D1074: Add Utxo Commitment wrapper around libsecp256k1.
Tue, Apr 23, 17:02
jasonbcox commandeered D1117: Integrate UtxoCommitment in CCoinView.
Tue, Apr 23, 17:01
jasonbcox commandeered D1150: [WIP] Extensible Blockchain Protocol first approach.
Tue, Apr 23, 17:01
jasonbcox abandoned D1367: add symlink option.
Tue, Apr 23, 17:01
jasonbcox abandoned D1277: WIP: Prototype structured key-value logger..
Tue, Apr 23, 17:00
jasonbcox commandeered D1277: WIP: Prototype structured key-value logger..
Tue, Apr 23, 17:00
jasonbcox commandeered D1367: add symlink option.
Tue, Apr 23, 16:59
jasonbcox abandoned D598: MalFix: Drop auto-requesting parents of orphans from the same peer.
Tue, Apr 23, 16:59
jasonbcox abandoned D613: MalFix: Drop support for GetTransaction lookups using the UTXO-index.
Tue, Apr 23, 16:59
jasonbcox commandeered D598: MalFix: Drop auto-requesting parents of orphans from the same peer.
Tue, Apr 23, 16:58
jasonbcox abandoned D597: MalFix: Drop lookup in UTXO set to prevent unneeded relay.
Tue, Apr 23, 16:58